Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KUI-1262): upgrade to KTH Style 10 #328

Merged
25 commits merged into from
Apr 17, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 12, 2024

Main goal of this PR is to upgrade KTH Style to version 10.

A short summary of what have been done:

  • Upgrading KTH packages and adding new @kth/style along side with old kth-style (the old will be deprecated)
  • General cleanup of DOM structure to algin with other Om kursen apps.
    • More cleanup in side-panel. Take an extra look at RoundInformationOneCol.jsx
  • New header and footer
  • New of style of all Buttons, Alerts and SideMenu
  • Added "prose" style to articles/text sections
  • General cleanup of style including font-family, colors and more.
  • Move of toolbar url (Personliga menyn) to parameters file to support ref version in ref/loaclhost

Some code are duplicated a cross different Om kursen repos. Such SCSS has been moved to shared.scss and components to /shared-components. PRs for other Om kursen apps that are upgraded at the same time with same structure:

@ghost ghost changed the title kth style 10 feat(KUI-1262): upgrade to KTH Style 10 Apr 15, 2024
@ghost ghost marked this pull request as ready for review April 15, 2024 11:17
@ghost ghost requested a review from belanglos April 15, 2024 11:17
Copy link
Contributor

@belanglos belanglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only found one unused prop.

public/js/app/components/RoundInformationOneCol.jsx Outdated Show resolved Hide resolved
@ghost ghost merged commit ce1b859 into master Apr 17, 2024
4 checks passed
@belanglos belanglos deleted the issues/KUI-1262-kth-style-10 branch June 12, 2024 05:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant