-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KUI-1390: added information modal to prerequisites #364
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7a3b080
Added information modal to recommended prerequisites
axelbjo 6631a2d
Fixed some incorrect namings in project
axelbjo 348b2a6
updated test
axelbjo 3887f23
Removed debugging html tags
axelbjo 35fc271
fix(KUI-1390): fix merge conflict and incorrect field name
axelbjo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* eslint-disable react/no-danger */ | ||
import React from 'react' | ||
import { FaAsterisk } from 'react-icons/fa' | ||
import InfoModal from './InfoModal' | ||
|
||
const syllabusMarker = (data, syllabusMarkerAriaLabel) => ( | ||
<h3> | ||
{data.header} | ||
{data.syllabusMarker && ( | ||
<sup> | ||
<FaAsterisk className="syllabus-marker-icon" aria-label={syllabusMarkerAriaLabel} /> | ||
</sup> | ||
)} | ||
{data.infoModal && ( | ||
<InfoModal | ||
title={data.header} | ||
infoText={data.infoModal.description} | ||
type="html" | ||
closeLabel={data.infoModal.closeLabel} | ||
ariaLabel={data.infoModal.ariaLabel} | ||
/> | ||
)} | ||
</h3> | ||
) | ||
|
||
// eslint-disable-next-line arrow-body-style | ||
const CourseSection = ({ sectionHeader: header = '', courseData = [], sectionId = '', syllabusMarkerAriaLabel }) => { | ||
return ( | ||
<div id={sectionId} aria-labelledby={`${sectionId}-header`}> | ||
{header.length ? <h2 id={`${sectionId}-header`}>{header}</h2> : null} | ||
{courseData.map(data => | ||
data.text ? ( | ||
<React.Fragment key={data.header || data.text}> | ||
{data.header && syllabusMarker(data, syllabusMarkerAriaLabel)} | ||
<div className="course-section-content-wrapper" dangerouslySetInnerHTML={{ __html: data.text }} /> | ||
</React.Fragment> | ||
) : null | ||
)} | ||
</div> | ||
) | ||
} | ||
|
||
export default CourseSection |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ import React from 'react' | |
|
||
import { useLanguage } from '../hooks/useLanguage' | ||
import { useMissingInfo } from '../hooks/useMissingInfo' | ||
import CourseSection from './CourseSections' | ||
import CourseSection from './CourseSection' | ||
import { SyllabusInformation } from './SyllabusInformation' | ||
|
||
function CourseSectionList({ courseInfo = {}, partToShow, syllabus = {}, syllabusName }) { | ||
|
@@ -61,7 +61,15 @@ function CourseSectionList({ courseInfo = {}, partToShow, syllabus = {}, syllabu | |
|
||
const during = [ | ||
...eligibility, | ||
{ header: translation.courseInformation.course_prerequisites, text: courseInfo.course_prerequisites }, | ||
{ | ||
header: translation.courseInformation.course_prerequisites, | ||
text: courseInfo.course_prerequisites, | ||
infoModal: { | ||
description: translation.courseInformation.course_prerequisites_description, | ||
closeLabel: translation.courseLabels.label_close, | ||
ariaLabel: translation.courseInformation.course_prerequisites_menu_aria_label, | ||
}, | ||
}, | ||
{ header: translation.courseInformation.course_required_equipment, text: courseRequiredEquipment }, | ||
{ header: translation.courseInformation.course_literature, text: literatureText }, | ||
] | ||
|
@@ -192,13 +200,15 @@ function CourseSectionList({ courseInfo = {}, partToShow, syllabus = {}, syllabu | |
sectionId="Content" | ||
syllabusMarkerAriaLabel={translation.courseLabels.syllabus_marker_aria_label} | ||
/> | ||
<p>Here comes the course execution</p> | ||
<CourseSection | ||
sectionHeader={translation.courseLabels.header_execution} | ||
headerType="3" | ||
courseData={getExecution()} | ||
sectionId="Execution" | ||
syllabusMarkerAriaLabel={translation.courseLabels.syllabus_marker_aria_label} | ||
/> | ||
<p>Here ends the course execution</p> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and this? |
||
<CourseSection | ||
sectionHeader={translation.courseLabels.header_examination} | ||
headerType="3" | ||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be here right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to clean up after myself, thank you!