Issues/KUI 1378 fetch data loader #369
Conversation
| <Item title={translation.courseRoundInformation.round_time_slots}> | ||
| <PlannedModules courseCode={courseCode} courseRound={courseRound} selectedSemester={selectedSemester} /> | ||
| <PlannedModules plannedModules={plannedModules} /> | ||
| </Item> |
There was a problem hiding this comment.
Now when call to usePlannedModules is moved up in the tree we can remove PlannedModules.jsx completly and just use the generic html-prop to <Item> here instead, like this:
<Item title={translation.courseRoundInformation.round_target_group} html={plannedModules} />
There was a problem hiding this comment.
Remove this file. See comment on RoundInformationInfoGrid.jsx
| () => ({ | ||
| basePath, | ||
| courseCode, | ||
| semester, |
There was a problem hiding this comment.
I found a bug, the semester prop in the params object is called selectedSemester and not semester, so semester is always undefined here.
There was a problem hiding this comment.
This still doesn't work for when I'm testing...
There was a problem hiding this comment.
Ah, it is still called semester in the planned modules api function. So it needs to be semester: selectedSemester, here.
Like this:
const requestData = useMemo(
() => ({
basePath,
courseCode,
semester: selectedSemester,
applicationCode,
}),
[basePath, courseCode, selectedSemester, applicationCode]
)
There was a problem hiding this comment.
You are absolutely right, I fixed it now; thanks for mentioning this.
| @@ -1,20 +1,26 @@ | |||
| import { useEffect, useState } from 'react' | |||
| import { STATUS } from './api/status' | |||
|
|
|||
| export const useApi = (apiToCall, initialApiParams, defaultValue, defaulValueIfNullResponse) => { | |||
| const [apiParams, setApiParams] = useState(initialApiParams) | |||
| export const useApi = (apiToCall, apiParams, defaultValue, defaulValueIfNullResponse) => { | |||
|
Thanks for your great comments, I applied the required changes based on them ⭐️ |
No description provided.