Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add affine transform util #322

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Conversation

jorendumoulin
Copy link
Contributor

@jorendumoulin jorendumoulin commented Jan 2, 2025

An AffineTransform helper, similar to the implementation in MLIR/xDSL.
However, the representation is handled by a matrix A and B instead of the AffineExpr tree, which should make things much easier. I plan to use this class inside the compiler/ir/stream/access_pattern.py utility classes.
This also gets rid of the canonicalization problem for affine transforms.

@jorendumoulin jorendumoulin force-pushed the joren/affine-transform-util branch 2 times, most recently from 803dc34 to 74198ea Compare January 2, 2025 12:34
@jorendumoulin jorendumoulin marked this pull request as ready for review January 2, 2025 12:52
@jorendumoulin jorendumoulin force-pushed the joren/affine-transform-util branch from d152f88 to 91ad679 Compare January 2, 2025 13:51
@jorendumoulin jorendumoulin force-pushed the joren/affine-transform-util branch from 1532138 to f9cc8fa Compare January 2, 2025 13:52
@JosseVanDelm
Copy link
Contributor

An AffineTransform helper, similar to the implementation in MLIR.

Can you link it please?

@jorendumoulin
Copy link
Contributor Author

An AffineTransform helper, similar to the implementation in MLIR.

Can you link it please?

there isn't a lot of useful information here but here you go: https://github.com/llvm/llvm-project/blob/main/mlir/lib/IR/AffineMap.cpp

Copy link
Contributor

@JosseVanDelm JosseVanDelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

@jorendumoulin jorendumoulin merged commit 43059c9 into main Jan 3, 2025
14 checks passed
@jorendumoulin jorendumoulin deleted the joren/affine-transform-util branch January 3, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants