-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transforms: (convert_stream_to_snax_stream) split up layout resolution pass #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR, but I think this requires a bit more granular testing and a bit more comments overall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The direction this is heading in is very exciting! Thanks @jorendumoulin!
Thank you for the extra docstrings!
nit: There's another one docstring missing though
I think it might make sense to split the testing for these passes up later down the line, but I agree that is not the main goal of this PR :)
1cd9b8b
to
b2bf8b9
Compare
situation before this pr:
The layout resolution includes a lot of gemmx specific hacks entagled between the logic of layout resolution, which is not nice. To keep everything clear this should be separated somewhat. This also makes it fit the mathematical model behind the passes more cleanly.
Therefore this pr splits it up into:
This PR doesn't change any logic, just separates it into two.