Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transforms: (convert_stream_to_snax_stream) split up layout resolution pass #337

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

jorendumoulin
Copy link
Contributor

@jorendumoulin jorendumoulin commented Jan 20, 2025

situation before this pr:

stream.streaming_region
 --> autoflow-scheduler-pattern
stream.schedule_op
 --> layout_resolution-pattern
snax_stream.streaming_region

The layout resolution includes a lot of gemmx specific hacks entagled between the logic of layout resolution, which is not nice. To keep everything clear this should be separated somewhat. This also makes it fit the mathematical model behind the passes more cleanly.

Therefore this pr splits it up into:

stream.streaming_region
 --> autoflow-scheduler-pattern
stream.schedule_op
 --> layout_resolution-pattern
stream.access_pattern_op
 --> convert_stream_to_snax_stream-pattern
snax_stream.streaming_region

This PR doesn't change any logic, just separates it into two.

@jorendumoulin jorendumoulin changed the title transforms: (convert_stream_to_snax_stream) split up layout resolutio… transforms: (convert_stream_to_snax_stream) split up layout resolution pass Jan 20, 2025
@jorendumoulin jorendumoulin marked this pull request as ready for review January 20, 2025 12:08
Copy link
Contributor

@JosseVanDelm JosseVanDelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, but I think this requires a bit more granular testing and a bit more comments overall

Copy link
Contributor

@JosseVanDelm JosseVanDelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction this is heading in is very exciting! Thanks @jorendumoulin!

Thank you for the extra docstrings!

nit: There's another one docstring missing though

I think it might make sense to split the testing for these passes up later down the line, but I agree that is not the main goal of this PR :)

@jorendumoulin jorendumoulin force-pushed the joren/split-layout-resolution branch from 1cd9b8b to b2bf8b9 Compare January 21, 2025 12:18
@jorendumoulin jorendumoulin merged commit 140db33 into main Jan 21, 2025
14 checks passed
@jorendumoulin jorendumoulin deleted the joren/split-layout-resolution branch January 21, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants