Code

Clean#14

Code

Open

hsonne wants to merge 29 commits intodevKWB-R/flextreat.hydrus1d:devfrom cleanKWB-R/flextreat.hydrus1d:cleanCopy head branch name to clipboard

+918-831

Commits

Commits on Oct 12, 2024

• Add/improve section label

  hsonne

  committed
  92a2912

  Copy full SHA for 92a2912

• Reindent

  hsonne

  committed
  0f8c88c

  Copy full SHA for 0f8c88c

• Loop over names instead of indices

  hsonne

  committed
  5e61a4c

  Copy full SHA for 5e61a4c

• Move function definition out of if (FALSE)

  hsonne

  committed
  9983cb0

  Copy full SHA for 9983cb0

• Simplify and generalise

  Show description for b3c59c0
  hsonne

  committed
  b3c59c0

  Copy full SHA for b3c59c0

• Do not next "if (FALSE)"

  hsonne

  committed
  7294310

  Copy full SHA for 7294310

• Clean section "Read and plot solute"

  hsonne

  committed
  cb60bc0

  Copy full SHA for cb60bc0

• Add and clean section "Read and plot balance"

  hsonne

  committed
  85b03bc

  Copy full SHA for 85b03bc

• Move things to where they belong

  hsonne

  committed
  0f7c0a6

  Copy full SHA for 0f7c0a6

• Add/clean more sections

  hsonne

  committed
  3beca45

  Copy full SHA for 3beca45

• Move tlevel expressions after tlevel assignment

  hsonne

  committed
  dc35e52

  Copy full SHA for dc35e52

• Move expressions to where they seem to belong

  hsonne

  committed
  2d035d9

  Copy full SHA for 2d035d9

Commits on Oct 13, 2024

• Get rid of duplication in "dry" and "wet" case

  hsonne

  committed
  6d26794

  Copy full SHA for 6d26794

• Integrate kd() into prepare_solute_input()

  hsonne

  committed
  c459abc

  Copy full SHA for c459abc

• Integrate get_mean() into provide_soil_columns()

  hsonne

  committed
  e581ea9

  Copy full SHA for e581ea9

• Integrate halftime_to_firstorderrate()

  Show description for ee72f27
  hsonne

  committed
  ee72f27

  Copy full SHA for ee72f27

• Use helper function index_of()

  hsonne

  committed
  e1a551b

  Copy full SHA for e1a551b

• Move MAIN section to the top of the script

  Show description for 758effd
  hsonne

  committed
  758effd

  Copy full SHA for 758effd

• Move provide_soil_columns() up

  hsonne

  committed
  97e68f0

  Copy full SHA for 97e68f0

• Extract period definition

  hsonne

  committed
  d45c3a1

  Copy full SHA for d45c3a1

• Use kwb.utils::startsToRanges() and compare

  Show description for f017790
  hsonne

  committed
  f017790

  Copy full SHA for f017790

• Keep only the new version

  hsonne

  committed
  9831b6a

  Copy full SHA for 9831b6a

• Rename generate_solute_ids()

  Show description for 272ad78
  hsonne

  committed
  272ad78

  Copy full SHA for 272ad78

• Move main loop up into MAIN section

  hsonne

  committed
  49ee82b

  Copy full SHA for 49ee82b

• Provide directory structure and files locally

  hsonne

  committed
  ceabdb9

  Copy full SHA for ceabdb9

• Move provide_paths() up

  hsonne

  committed
  e9dc490

  Copy full SHA for e9dc490

• Replace path constant with placeholder

  Show description for 662f107
  hsonne

  committed
  662f107

  Copy full SHA for 662f107

• Return early, use inline assignment

  hsonne

  committed
  1cddc08

  Copy full SHA for 1cddc08

• WIP

  hsonne

  committed
  e7b2062

  Copy full SHA for e7b2062