adding Undo and Redo in Source editor #308 #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
reviewed
Nov 23, 2023
lordrip
reviewed
Nov 23, 2023
|
the undo / redo buttons currently have an issue. they only react every 3 clicks in a visible way. It seems that the set code is not the right one on the first click. this needs further investigation before we merge |
|
@lhein I was also trying to figure out the cause of the issue - already reported in patternfly-react: patternfly/patternfly-react#9838 I suspect that the issue is the same, which is affecting the "Ctrl+Z" behaviour I reported there. |
|
While this issue is being investigated in PatternFly side and this issue also occoring in the live online examples at the patternfly homepage / docs I am suggesting to go forward an merge the PR as this isn't a problem in our code base. Once all PR checks pass of course ;) |
Co-authored-by: Ricardo M. <lordrip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #308