Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add missing settings to VS Code Kaoto #756

Merged
merged 1 commit into from
Jan 8, 2025
Merged

feat: Add missing settings to VS Code Kaoto #756

merged 1 commit into from
Jan 8, 2025

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Jan 8, 2025 •
edited
Loading

Settings page

image

apupier
apupier requested changes Jan 8, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
apupier
apupier reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: the commit message is mentioning a "chore" but it is a new feature (even if it felt like a chore maybe :p)

@lordrip lordrip force-pushed the chore/add-experimental-features branch 2 times, most recently from 4694edf to de194bf Compare January 8, 2025 10:29
@lordrip lordrip changed the title chore: Add experimental features to VS Code Kaoto feat: Add missing settings to VS Code Kaoto Jan 8, 2025
@lordrip lordrip force-pushed the chore/add-experimental-features branch from de194bf to 01cd617 Compare January 8, 2025 10:32
@lordrip lordrip requested review from apupier and djelinek January 8, 2025 10:32
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lordrip lordrip mentioned this pull request Jan 8, 2025
Merged
@lordrip lordrip merged commit 607e99b into KaotoIO:main Jan 8, 2025
7 checks passed
@lordrip lordrip deleted the chore/add-experimental-features branch January 8, 2025 11:14
@apupier
Copy link
Member

apupier commented Jan 8, 2025

argh forgot that we should add the mention that " It requires to reopen the kaoto editors to be effective."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djelinek djelinek djelinek approved these changes

@apupier apupier apupier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lordrip @apupier @djelinek