Kimai v2 latest #22
Merged
Kimai v2 latest #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to solve this problem at log: > User Deprecated: Context: Passing values to option `--all-or-nothing` Problem: Passing values is deprecated Identified that this prolem stay at Kimai side, but is good to upgrade. ref: doctrine/migrations#1383 Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
When we access a key of array that don't exists, throw an exception, to prevent this I used the empty constructor Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
the most fast way to do this but not the best way because isn't locally Signed-off-by: Vitor Mattos <vitor@php.rio>
Use server timezone when the use haven't a timezone Signed-off-by: Vitor Mattos <vitor@php.rio>
|
The overtime also has some issues. I am still struggeling with the API. Does these work in your environment? You can to click your profile -> API access and then click the book icon "swagger api doc". When you have defined an api key, on the swagger api you can test it by authorization (use your username and api passoword) and then go to the api endpoint to test. The swagger API doc does not open for me "{"code":500,"message":"Internal Server Error"}" - when I remove all approval APIs (rename .php to .php_ for example), then the doc is up and running. Nevertheless, I already merge so that can be used as base. |
KatjaGlassConsulting
merged commit 22ab6cc
into
KatjaGlassConsulting:kimai_v2_update
0 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @KatjaGlassConsulting
I fixed more issues and I think that #21 was solved now (but I didn't tested).
Now, I identified a problem when reject a week.
When I click at button "reject", don't do nothing.
But, I was able to approve a work week now with success.
I followed doing all commits separated to be more easy to do the review.