revert fix_private_attribute (#17)

KazuCocoa · Jan 1, 2018 · 224ec84 · 224ec84
1 parent 786ccd7
commit 224ec84
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 62 deletions.
diff --git a/lib/ex_parameterized/params.ex b/lib/ex_parameterized/params.ex
@@ -10,22 +10,6 @@ defmodule ExUnit.Parameterized.Params do
       [{:{}, _, [{:%{}, _, _}]}] ->
         ast |> do_test_with(desc, fun)
 
-      # for @param
-      {:@, _, [{atom, _, _}]} ->
-        quote do
-          attr =
-            Module.get_attribute(unquote(__CALLER__.module), unquote(atom))
-            |> Macro.escape()
-
-          # [{:test, [],
-          #   ["'bad': number of 0",
-          #     [do: {{:., [],
-          #       [#Function<1.14669326 in file:test/ex_parameterized_test.exs>]}, [],
-          #         [1]}]]}]
-          do_test_with(attr, unquote(desc), unquote(fun))
-          # If we can run the above AST, test will run.
-        end
-
       _ ->
         try do
           {params, _} = Code.eval_quoted(params_ast)
@@ -37,7 +21,7 @@ defmodule ExUnit.Parameterized.Params do
     end
   end
 
-  def do_test_with(ast, desc, fun) do
+  defp do_test_with(ast, desc, fun) do
     ast
     |> param_with_index()
     |> Enum.map(fn param ->

diff --git a/lib/ex_parameterized/params_callback.ex b/lib/ex_parameterized/params_callback.ex
@@ -10,22 +10,6 @@ defmodule ExUnit.Parameterized.ParamsCallback do
       [{:{}, _, [{:%{}, _, _}]}] ->
         ast |> do_test_with(desc, context, fun)
 
-      # for @param
-      {:@, _, [{atom, _, _}]} ->
-        quote do
-          attr =
-            Module.get_attribute(unquote(__CALLER__.module), unquote(atom))
-            |> Macro.escape()
-
-          # [{:test, [],
-          #   ["'bad': number of 0",
-          #     [do: {{:., [],
-          #       [#Function<1.14669326 in file:test/ex_parameterized_test.exs>]}, [],
-          #         [1]}]]}]
-          do_test_with(attr, unquote(desc), unquote(fun))
-          # If we can run the above AST, test will run.
-        end
-
       _ ->
         try do
           {params, _} = params_ast |> Code.eval_quoted()
@@ -40,7 +24,7 @@ defmodule ExUnit.Parameterized.ParamsCallback do
     end
   end
 
-  def do_test_with(ast, desc, context, fun) do
+  defp do_test_with(ast, desc, context, fun) do
     ast
     |> param_with_index()
     |> Enum.map(fn param ->

diff --git a/test/ex_parameterized_callback_test.exs b/test/ex_parameterized_callback_test.exs
@@ -119,18 +119,4 @@ defmodule ExParameterizedParamsCallbackTest do
       "description for param2": {"hello", context[:hello], "hello and world"}
     ]
   end
-
-  @params [{1}]
-  test_with_params "bad", context, fn a ->
-    assert a == 1
-  end do
-    @params
-  end
-
-  @params2 [{1}, {1}]
-  test_with_params "bad", context, fn a ->
-    assert a == 1
-  end do
-    @params2
-  end
 end
diff --git a/test/ex_parameterized_test.exs b/test/ex_parameterized_test.exs
@@ -153,18 +153,4 @@ defmodule ExParameterizedTest do
   end do
     Enum.map([{["a", "b"]}], fn x -> x end)
   end
-
-  @params [{1}]
-  test_with_params "bad", fn a ->
-    assert a == 1
-  end do
-    @params
-  end
-
-  @params2 [{1}, {1}]
-  test_with_params "bad", fn a ->
-    assert a == 1
-  end do
-    @params2
-  end
 end