Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/idempotent draft imports #79

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

akfakmot
Copy link
Collaborator

Motivation

Implement more manual strategy for draft imports that preserves import idempotence

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Import basic.json and run automatic tests or test content tree of web channel manually for any sign of expectation mismatch and error

Modify: Make ContentItemSimplifiedModel draft imports manual and idempotent
Chore: Serialize samples to match current SampleProvider code
@akfakmot akfakmot requested a review from tkrch November 26, 2024 17:21
@akfakmot akfakmot merged commit 6a1be9b into main Dec 2, 2024
2 checks passed
@akfakmot akfakmot deleted the feat/idempotent-draft-imports branch December 2, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants