Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization of text #2

Merged
merged 1 commit into from
Jun 18, 2015
Merged

Localization of text #2

merged 1 commit into from
Jun 18, 2015

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jun 15, 2015

Localization of text and small changed in styling. Fix for #1

I have used the localizationService to get the keys from /Umbraco/Config/Lang with the simple syntax localizationService.dictionary['area_key'].
It can also be used like the following:

localizationService.localize(str)
    .always(function(response) {
        console.log("[" + str + "]");
    })
    .then(function (value) {
        var text = value != null ? value : "";
        console.log(text);
    });

Futhermore I have prepared for Umbraco 7.3.0, where it will be possible to ship language files with the package: http://issues.umbraco.org/issue/U4-5777 ... for now just add the keys from the languages files to the core Umbraco file. Another approach is to use a package action like this https://github.com/warrenbuckley/Analytics/blob/develop/Analytics/InstallHelpers.cs#L20 to insert the language keys into the core language files.

Finally a have modified the styles a bit and I noticed a console error sometimes happened because mytime object sometimes was null.

image

Localization of text and small changed in styling.
KevinJump added a commit that referenced this pull request Jun 18, 2015
@KevinJump KevinJump merged commit ee806da into KevinJump:master Jun 18, 2015
@KevinJump
Copy link
Owner

Top notch bit of fixing that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants