Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootbuilder: add debug log in rootbuilder_copy #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

achekery
Copy link

@achekery achekery commented May 1, 2023

No description provided.

@achekery
Copy link
Author

achekery commented May 1, 2023

Please refer my issue -- #7

@Kezyma
Copy link
Owner

Kezyma commented May 1, 2023

You need to change the imports to match the appropriate PyQt version, as these changes will currently break on MO 2.5
You'll also need to modify the str() parts to add appropriate encoding as it will throw errors if any unusual characters are included.

Those, and the possibility for incredibly large amounts of log spam on some games, are the main reasons the lines are commented out!

@achekery
Copy link
Author

achekery commented May 2, 2023

You need to change the imports to match the appropriate PyQt version, as these changes will currently break on MO 2.5 You'll also need to modify the str() parts to add appropriate encoding as it will throw errors if any unusual characters are included.

Those, and the possibility for incredibly large amounts of log spam on some games, are the main reasons the lines are commented out!

OK. I will take a look around later to see what else would be needed.

Does this project already have a config file that could be extended to support a field the user can manually edit to intentionally "opt in" for this possibly performance breaking change? Then change the qDebug call to a wrapper that is disabled unless the config field was set.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants