Fix #89

KnpLabs · Oct 17, 2018 · f3b399e · f3b399e
1 parent e35c93a
commit f3b399e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/spec/Knp/DictionaryBundle/Dictionary/ValueTransformer/ConstantTransformerSpec.php b/spec/Knp/DictionaryBundle/Dictionary/ValueTransformer/ConstantTransformerSpec.php
@@ -20,6 +20,11 @@ function it_doesnt_support_non_constant_pattern_values()
         $this->supports('foo')->shouldReturn(false);
     }
 
+    function it_doesnt_support_integers()
+    {
+        $this->supports(0)->shouldReturn(false);
+    }
+
     function it_doesnt_support_non_existing_classes()
     {
         $this->supports('My\Awesome\Non\Existing\Class::CONST')->shouldReturn(false);

diff --git a/src/Knp/DictionaryBundle/Dictionary/ValueTransformer/ConstantTransformer.php b/src/Knp/DictionaryBundle/Dictionary/ValueTransformer/ConstantTransformer.php
@@ -19,6 +19,10 @@ class ConstantTransformer implements ValueTransformer
      */
     public function supports($value): bool
     {
+        if (false === \is_string($value)) {
+            return false;
+        }
+
         $matches = [];
 
         if (0 === preg_match($this->pattern, $value, $matches)) {