Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest sync, update workflows #571

Merged
merged 13 commits into from
Mar 16, 2023

Conversation

SirSevenG
Copy link

@SirSevenG SirSevenG commented Feb 25, 2023

Sync pytests with research branch
Minor tests fixes to correctly work with dev branch
Switch to 30s blocktime bootstrap for pytests
Update version of GH actions from deprecated ones (v1 -> v3) https://github.com/actions/checkout https://github.com/actions/upload-artifact https://github.com/actions/download-artifact

Fix windows CI build

@dimxy @DeckerSU There are issues with macOS build, I don't have Intel mac to recheck locally and it's problematic to debug the build in Actions - macOS eats Actions usage time too fast. Please take a look when you can.

Draft for now, need to fix macOS first. Still an improvement over current state. )

Also should close: #560

@SirSevenG SirSevenG marked this pull request as ready for review February 28, 2023 11:34
@smk762 smk762 requested review from Alrighttt, DeckerSU and dimxy March 7, 2023 13:32
@dimxy
Copy link
Collaborator

dimxy commented Mar 8, 2023

win tests work, great!

@smk762 smk762 self-requested a review March 16, 2023 07:37
@smk762 smk762 changed the base branch from dev to ci-tests-update March 16, 2023 15:21
@smk762 smk762 merged commit 5019539 into KomodoPlatform:ci-tests-update Mar 16, 2023
@dimxy
Copy link
Collaborator

dimxy commented Mar 16, 2023

There are issues with macOS build, I don't have Intel mac to recheck locally and it's problematic to debug the build in Actions - macOS eats Actions usage time too fast. Please take a look when you can.

I regularly build on intel mac without any issues and I have never seen errors like in this github mac build.

@smk762
Copy link

smk762 commented Mar 16, 2023

I've merged this into #575 for working on fixing the mac builds. So far got it working on macos-11, but not yet on macos-12 / macos-latest runners

@DeckerSU
Copy link

I regularly build on intel mac without any issues and I have never seen errors like in this github mac build.

macOS 12 (Monterrey) and latest XCode 14.2 (Build version 14C18) introduces many issues into our build. For example, Rust 1.32 produced a slightly invalid format .rlibs that newer versions of xcode are more restrictive on. So, there is a two possible solutions: downgrade XCode to 13.2.1 or upgrade Rust to 1.54 or newer. Also, seems gcc@8 produce an incorrect binaries on macOS 12 somehow ... I just have finished fixing the issues with native Mac x86_64 build for KomodoOcean ... and now will focus on komodod.

@TheComputerGenie
Copy link

Given that gcc 8 series is so old that it hasn't been supported by GNU for nearly 2 years, it would seem that the "proper" path forward would be to update any code which no longer meets industry standards.

who-biz pushed a commit to who-biz/komodo that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants