-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Season 8 pubkeys and update hardfork constants #620
Conversation
Better solution for the issues mentioned in #589 .
allow -ac_private for the ZOMBIE test chain
These changes should go directly into the |
Conflicts have been resolved here. To finalize the changes in
Afterward, we need to create a final PR to merge the remaining changes into |
const uint32_t nS8Timestamp = 1726321053; // dPoW Season 8, Sat Sep 14 2024 13:37:33 GMT+0000 | ||
const int32_t nS8HardforkHeight = 4100333; // dPoW Season 8, Sat Sep 14 2024 | ||
const uint32_t nS8Timestamp = 1728049053; // dPoW Season 8, Fri Oct 4 2024 13:37:33 GMT+0000 | ||
const int32_t nS8HardforkHeight = 4125988; // dPoW Season 8, Fri Oct 4 2024 (est. via https://github.com/KomodoPlatform/NotaryNodes/blob/master/utils/estimate_hf_block.py) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this should be (re)calculated as late as possible to make it as accurate as possible wrt to recent/anticipated block production rate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will recalc tonight and include in #623
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created my own script for these calculations, which you can find here: estimate-blocks.py. According to my calculations, we have the following:
- Average blocks per day: 1370.96
- Minimum blocks per day: 1260
- Maximum blocks per day: 1457
- Current height: 4063104
- Days to future: 45
- Estimated block height at 2024-10-04 13:37:33: 4124797
Based on this, October 4th
corresponds to approximately block 4124797
on average. Currently, we have 4125988
hardcoded, which should occur later than 2024-10-04 13:37:33
. So, my guess is that 4125988
is okay.
Harvested from https://docs.google.com/spreadsheets/d/1qcRn6YF_UdjeSJxSz80nS1cqpqS-5x0NnGKo9VJPPq8/edit?usp=sharing
Related dPoW PR at KomodoPlatform/dPoW#563