Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Season 8 pubkeys and update hardfork constants #620

Merged
merged 9 commits into from
Aug 19, 2024

Conversation

smk762
Copy link

@smk762 smk762 commented Aug 8, 2024

@DeckerSU
Copy link

DeckerSU commented Aug 8, 2024

These changes should go directly into the patch-s8-prepare branch, and then it should be merged with dev. The patch-s8-prepare branch already has everything needed, including constants, etc. The main purpose of this branch is to have a state where we only need to replace the pubkeys.

@smk762 smk762 changed the base branch from dev to patch-s8-prepare August 8, 2024 15:55
@DeckerSU
Copy link

DeckerSU commented Aug 9, 2024

Conflicts have been resolved here. To finalize the changes in dev, we need to approve the following:

  1. PR Remove libsnark, libgmp, mini-gmp #613 (patch-remove-libsnark -> dev)
  2. PR build: use native clang as darwin compiler #618 (patch-macos-build-clang -> patch-remove-libsnark)
  3. PR fix datacarrier related command-line args #619 (patch-data-carrier -> dev)
  4. PR Add Season 8 pubkeys and update hardfork constants #620 (add/s8-pubkeys -> patch-s8-prepare, which already contains patch-remove-libsnark, patch-macos-build-clang, and KIP0002 + KIP0003 changes)

Afterward, we need to create a final PR to merge the remaining changes into dev, with final checks. I can handle the merge and resolve any potential conflicts myself, but I'll need the reviewers' approval of PRs (1)-(4) first.

DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Aug 9, 2024
const uint32_t nS8Timestamp = 1726321053; // dPoW Season 8, Sat Sep 14 2024 13:37:33 GMT+0000
const int32_t nS8HardforkHeight = 4100333; // dPoW Season 8, Sat Sep 14 2024
const uint32_t nS8Timestamp = 1728049053; // dPoW Season 8, Fri Oct 4 2024 13:37:33 GMT+0000
const int32_t nS8HardforkHeight = 4125988; // dPoW Season 8, Fri Oct 4 2024 (est. via https://github.com/KomodoPlatform/NotaryNodes/blob/master/utils/estimate_hf_block.py)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current estimation for height 4125988 is October 1st

cc @DeckerSU @smk762

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this should be (re)calculated as late as possible to make it as accurate as possible wrt to recent/anticipated block production rate.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will recalc tonight and include in #623

Copy link

@DeckerSU DeckerSU Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created my own script for these calculations, which you can find here: estimate-blocks.py. According to my calculations, we have the following:

- Average blocks per day: 1370.96
- Minimum blocks per day: 1260
- Maximum blocks per day: 1457
- Current height: 4063104
- Days to future: 45
- Estimated block height at 2024-10-04 13:37:33: 4124797

Based on this, October 4th corresponds to approximately block 4124797 on average. Currently, we have 4125988 hardcoded, which should occur later than 2024-10-04 13:37:33. So, my guess is that 4125988 is okay.

@ca333 ca333 merged commit e75479e into patch-s8-prepare Aug 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants