Set unreliable_quality compression to 2x base quality

KonaeAkira · Aug 31, 2024 · 33d3a8a · 33d3a8a
1 parent 9222761
commit 33d3a8a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/solvers/src/quality_upper_bound_solver/solver.rs b/solvers/src/quality_upper_bound_solver/solver.rs
@@ -364,7 +364,7 @@ mod tests {
                 Action::Groundwork,
             ],
         );
-        assert_eq!(result, 3974);
+        assert_eq!(result, 3975);
     }
 
     #[test]
@@ -474,7 +474,7 @@ mod tests {
             adversarial: true,
         };
         let result = solve(settings, &[Action::MuscleMemory]);
-        assert_eq!(result, 1883);
+        assert_eq!(result, 1888);
     }
 
     #[test]

diff --git a/solvers/src/quality_upper_bound_solver/state.rs b/solvers/src/quality_upper_bound_solver/state.rs
@@ -22,9 +22,9 @@ impl ReducedState {
         let great_strides_active = state.effects.great_strides() != 0;
         Self {
             cp,
-            // compress into units of base_quality, rounded up
-            unreliable_quality: ((state.unreliable_quality + base_quality - 1) / base_quality)
-                as u8,
+            // compress into units of 2 * base_quality, rounded up
+            unreliable_quality: ((state.unreliable_quality + 2 * base_quality - 1)
+                / (2 * base_quality)) as u8,
             combo: state.combo,
             effects: state
                 .effects
@@ -40,7 +40,7 @@ impl ReducedState {
             cp: self.cp,
             progress: 0,
             quality: 0,
-            unreliable_quality: self.unreliable_quality as u16 * base_quality,
+            unreliable_quality: self.unreliable_quality as u16 * base_quality * 2,
             effects: self.effects,
             combo: self.combo,
         }