-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accelerate yacht train
#125
Conversation
Hi @chunyuma, as this is now implemented in KoslickiLab/fast_yacht_train#3, do I still need to add the cpp code in the repository? Also, it looks like some code duplication has blocked this PR. What are your plans on this? Do you want me to take some things off your plate? |
No worries @mahmudhera. I can handle the rest. I have added your cpp scripts to YACHT and they looks good. I just need a few more tests. |
Excellent, LMK if I can help. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 85.18% 83.44% -1.75%
==========================================
Files 11 11
Lines 1080 1081 +1
==========================================
- Hits 920 902 -18
- Misses 160 179 +19 ☔ View full report in Codecov by Sentry. |
Hello @chunyuma I see some tests blocking the merge. Do you want me to work on any of these? |
Thank @mahmudhera, it is not a block but the merging needs at least 1 approving review. The code has passed all tests now. But there are some problems about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but cautiously waiting for @dkoslicki to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see, this looks good to me. @chunyuma LMK when the conda issue is resolved and you or I can merge this in
Co-authored-by: Chunyu Ma <machunyu4402@gmail.com> Co-authored-by: Mahmudur Rahman Hera <mahmudhera93@gmail.com>
Quality Gate passedIssues Measures |
This PR is created to integrate Mahmudur's new algorithm and post-processing method written with cpp script to accelerate
yacht train
We need to do the following tasks:
main
branch