Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate yacht train #125

Merged
merged 26 commits into from
Nov 5, 2024
Merged

Accelerate yacht train #125

merged 26 commits into from
Nov 5, 2024

Conversation

chunyuma
Copy link
Member

@chunyuma chunyuma commented Oct 20, 2024

This PR is created to integrate Mahmudur's new algorithm and post-processing method written with cpp script to accelerate yacht train

We need to do the following tasks:

  • add the cpp scripts into the branch (under ./yacht/cpp_scripts) @mahmudhera.
  • modify related scripts for integrating these cpp scripts in YACHT @chunyuma
  • create a makefile and other related scripts for pre-processing @mahmudhera @chunyuma
  • modify some tests @chunyuma
  • integrate into the main branch

@mahmudhera
Copy link
Member

Hi @chunyuma, as this is now implemented in KoslickiLab/fast_yacht_train#3, do I still need to add the cpp code in the repository? Also, it looks like some code duplication has blocked this PR. What are your plans on this? Do you want me to take some things off your plate?

@chunyuma
Copy link
Member Author

chunyuma commented Nov 4, 2024

No worries @mahmudhera. I can handle the rest. I have added your cpp scripts to YACHT and they looks good. I just need a few more tests.

@mahmudhera
Copy link
Member

Excellent, LMK if I can help.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 62.26415% with 20 lines in your changes missing coverage. Please review.

Project coverage is 83.44%. Comparing base (be99fe4) to head (4f09e53).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
src/yacht/utils.py 59.18% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   85.18%   83.44%   -1.75%     
==========================================
  Files          11       11              
  Lines        1080     1081       +1     
==========================================
- Hits          920      902      -18     
- Misses        160      179      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahmudhera
Copy link
Member

Hello @chunyuma I see some tests blocking the merge. Do you want me to work on any of these?

@chunyuma
Copy link
Member Author

chunyuma commented Nov 4, 2024

Thank @mahmudhera, it is not a block but the merging needs at least 1 approving review. The code has passed all tests now. But there are some problems about conda install I need to figure out before merging. I will let you know when it is done.

Copy link
Member

@mahmudhera mahmudhera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but cautiously waiting for @dkoslicki to approve.

dkoslicki
dkoslicki previously approved these changes Nov 5, 2024
Copy link
Member

@dkoslicki dkoslicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, this looks good to me. @chunyuma LMK when the conda issue is resolved and you or I can merge this in

Co-authored-by: Chunyu Ma <machunyu4402@gmail.com>
Co-authored-by: Mahmudur Rahman Hera <mahmudhera93@gmail.com>
mahmudhera
mahmudhera previously approved these changes Nov 5, 2024
Copy link

sonarqubecloud bot commented Nov 5, 2024

@chunyuma chunyuma merged commit 5628ee0 into main Nov 5, 2024
6 checks passed
@chunyuma chunyuma deleted the dev-patch-NEW-algorithm branch November 5, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants