Make serial descriptor equality (and hashcode) include the declared (use side) element names, rather than only the serial names of the element types. #2862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xml parser uses the serial descriptor as part of the lookup key for extended type information. However, this does not work correctly if two serial descriptors have the same name and member types, even if the element names are different. This pull request includes the declared element names as part of the hash key and equals checking (I know that multiple types with the same
@SerialName
is not supposed to work, but with this change it at least breaks less.The underlying bug is pdvrieze/xmlutil#254.