Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rootless heplike #3

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Rootless heplike #3

wants to merge 28 commits into from

Conversation

tegonzalo
Copy link
Collaborator

This is a branch that allows to use heplike almost completely rootless. Every single class or function that is needed in gambit now offers a 100% rootless version. The only classes that I have not de-rootified are those we do not used in gambit (e.g. HL_ExpPoints), but the principle should apply anyway if we ever need to do it.

@mchrzasz please review this at your leasure and when you're happy we should make a new release (1.4 or even 2.0 given the amount of changes), so we can use it in gambit.

@tegonzalo tegonzalo requested a review from mchrzasz December 2, 2022 14:48
@philiptgrace
Copy link

@tegonzalo, for the $B\to\mu\mu$ likelihoods, I've been getting the following error:

gsl: interp2d.c:143: ERROR: interpolation x value out of range
Default GSL error handler invoked.

I have attached a YAML file which produces this error when run on the rootless_heplike branch: WC.txt

@tegonzalo
Copy link
Collaborator Author

tegonzalo commented Feb 24, 2023

@tegonzalo, for the B→μμ likelihoods, I've been getting the following error:

gsl: interp2d.c:143: ERROR: interpolation x value out of range
Default GSL error handler invoked.

I have attached a YAML file which produces this error when run on the rootless_heplike branch: WC.txt

I need the values of the WCs to reproduce the error, they should have been printed to screen with the error, do you have them?

@tegonzalo
Copy link
Collaborator Author

Nevermind, I managed to reproduce it and fixed it. The fixed version is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants