-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rootless heplike #3
base: master
Are you sure you want to change the base?
Conversation
@tegonzalo, for the
I have attached a YAML file which produces this error when run on the |
I need the values of the WCs to reproduce the error, they should have been printed to screen with the error, do you have them? |
Nevermind, I managed to reproduce it and fixed it. The fixed version is here |
This is a branch that allows to use heplike almost completely rootless. Every single class or function that is needed in gambit now offers a 100% rootless version. The only classes that I have not de-rootified are those we do not used in gambit (e.g. HL_ExpPoints), but the principle should apply anyway if we ever need to do it.
@mchrzasz please review this at your leasure and when you're happy we should make a new release (1.4 or even 2.0 given the amount of changes), so we can use it in gambit.