[SearchBundle, NodeSearchBundle] : change nGram to ngram
#3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
requested changes
Feb 8, 2024
src/Kunstmaan/NodeSearchBundle/Configuration/NodePagesConfiguration.php
Outdated
Show resolved
Hide resolved
|
Thank you @delboy1978uk |
acrobat
added a commit
that referenced
this pull request
Feb 18, 2024
* 6.x: feature #3331 [SearchBundle, NodeSearchBundle] : change `nGram` to `ngram` (delboy1978uk)
acrobat
added a commit
that referenced
this pull request
Feb 18, 2024
* 7.0: feature #3331 [SearchBundle, NodeSearchBundle] : change `nGram` to `ngram` (delboy1978uk)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using elastic search 8, elastica throws the following Exception
The [nGram] tokenizer name was deprecated in 7.6. Please use the tokenizer name to [ngram] for indices created in versions 8 or higher instead.
Version 7 uses ngram as well as nGram as can be seen here, https://www.elastic.co/guide/en/elasticsearch/reference/7.14/analysis-ngram-tokenizer.html#_example_output_13 , so this pull request simply lower cases the G's, which allows the search population command to successfully run again