Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cluster CRUD APIs, credential masking, search pagination and OpenAPI docs #111

Merged
merged 7 commits into from
Dec 14, 2023
Merged

feat: cluster CRUD APIs, credential masking, search pagination and OpenAPI docs #111

merged 7 commits into from
Dec 14, 2023

Conversation

ffforest
Copy link
Collaborator

@ffforest ffforest commented Dec 13, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adding cluster CRUD APIs
  • Adding cluster display name and description
  • Credential masking when fetching cluster
  • Search pagination with page and pageSize
  • Standardized API responses
  • Updated OpenAPI docs for cluster and insight APIs

@ffforest ffforest changed the title Feat: Adding cluster CRUD APIs, credential masking, search pagination, standardized responses and OpenAPI docs feat: Adding cluster CRUD APIs, credential masking, search pagination, standardized responses and OpenAPI docs Dec 13, 2023
@ffforest ffforest changed the title feat: Adding cluster CRUD APIs, credential masking, search pagination, standardized responses and OpenAPI docs feat: adding cluster CRUD APIs, credential masking, search pagination, standardized responses and OpenAPI docs Dec 13, 2023
@ffforest ffforest changed the title feat: adding cluster CRUD APIs, credential masking, search pagination, standardized responses and OpenAPI docs feat: cluster CRUD APIs, credential masking, search pagination and OpenAPI docs Dec 13, 2023
@ffforest ffforest added this to the v0.3.0 milestone Dec 13, 2023
@ffforest ffforest linked an issue Dec 14, 2023 that may be closed by this pull request
Cluster Management: CRUD for Cluster CR #82
Closed
@ffforest ffforest linked an issue Dec 14, 2023 that may be closed by this pull request
Search: Search result pagination #114
Closed
@elliotxx elliotxx assigned ffforest and unassigned elliotxx and panshuai111 Dec 14, 2023
@ffforest
Copy link
Collaborator Author

Search hit total count, page and page size:
URL: https://localhost:7443/api/v1/resource/search?query=select%20*%20from%20resources%20where%20namespace%20=%20%27mybkbkmi%27&pattern=sql&pageSize=2&page=2
image
page defaults to 1, pageSize defaults to 10 if omitted from url query:
image

elliotxx
elliotxx reviewed Dec 14, 2023
View reviewed changes
pkg/core/manager/cluster/manager.go Outdated Show resolved Hide resolved
pkg/core/manager/cluster/manager.go Outdated Show resolved Hide resolved
pkg/core/manager/cluster/manager.go Outdated Show resolved Hide resolved
pkg/core/manager/cluster/manager.go Outdated Show resolved Hide resolved
pkg/core/manager/cluster/manager.go Outdated Show resolved Hide resolved
pkg/core/manager/cluster/manager.go Outdated Show resolved Hide resolved
elliotxx
elliotxx approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ffforest ffforest merged commit f0c18f6 into main Dec 14, 2023
5 checks passed
@ffforest ffforest deleted the feat-cluster-crud branch December 14, 2023 06:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@panshuai111 panshuai111 Awaiting requested review from panshuai111 panshuai111 is a code owner

@adohe adohe Awaiting requested review from adohe adohe is a code owner

Assignees

@ffforest ffforest

Labels
area/cluster-mgmt
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Search: Search result pagination Cluster Management: CRUD for Cluster CR
3 participants
@ffforest @elliotxx @panshuai111