Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: consolidate url paths and use locator for api calls #148

Merged
merged 7 commits into from
Dec 22, 2023
Merged

refactor: consolidate url paths and use locator for api calls #148

merged 7 commits into from
Dec 22, 2023

Conversation

ffforest
Copy link
Collaborator

What type of PR is this?

/kind refactor

What this PR does / why we need it:

  • Consolidate all URL path into /search, /insight and /cluster
  • Use core.Locator instead of resource.Resource in all methods

@ffforest ffforest added the enhancement New feature or request label Dec 21, 2023
@ffforest ffforest added this to the v0.3.0 milestone Dec 21, 2023
elliotxx
elliotxx reviewed Dec 22, 2023
View reviewed changes
pkg/core/handler/events/events.go Outdated Show resolved Hide resolved
pkg/core/handler/resource/resource.go Outdated Show resolved Hide resolved
pkg/core/handler/resource/resource.go Outdated Show resolved Hide resolved
pkg/core/handler/search/search.go Show resolved Hide resolved
pkg/core/handler/search/search.go Outdated Show resolved Hide resolved
pkg/core/handler/summary/summary.go Show resolved Hide resolved
pkg/core/handler/summary/summary.go Outdated Show resolved Hide resolved
pkg/core/handler/topology/topology.go Outdated Show resolved Hide resolved
@ffforest
Copy link
Collaborator Author

Updated openapi annotations and resolved the comments.

@elliotxx elliotxx enabled auto-merge (squash) December 22, 2023 07:48
@elliotxx elliotxx merged commit 1b4adcc into main Dec 22, 2023
5 checks passed
@elliotxx elliotxx deleted the fix-url-format-and-locator branch December 22, 2023 07:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@ffforest ffforest linked an issue Dec 22, 2023 that may be closed by this pull request
Consolidate API paths and use locator for all resources or aggregations #150
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@panshuai111 panshuai111 Awaiting requested review from panshuai111 panshuai111 is a code owner

@adohe adohe Awaiting requested review from adohe adohe is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Consolidate API paths and use locator for all resources or aggregations
2 participants
@ffforest @elliotxx