Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: consolidate api managers #156

Merged
merged 2 commits into from
Dec 23, 2023
Merged

refactor: consolidate api managers #156

merged 2 commits into from
Dec 23, 2023

Conversation

ffforest
Copy link
Collaborator

What type of PR is this?

/kind refactor

What this PR does / why we need it:

  • Re-arranged API managers and make sure they align with handlers
  • Audit and Score will be moved later to avoid conflicts

@ffforest ffforest added the enhancement New feature or request label Dec 22, 2023
@ffforest ffforest added this to the v0.3.0 milestone Dec 22, 2023
elliotxx
elliotxx approved these changes Dec 23, 2023
View reviewed changes
Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit 910217c into main Dec 23, 2023
5 checks passed
@elliotxx elliotxx deleted the add-more-aggregation-summary branch December 23, 2023 08:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@panshuai111 panshuai111 Awaiting requested review from panshuai111 panshuai111 is a code owner

@adohe adohe Awaiting requested review from adohe adohe is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ffforest @elliotxx