Skip to content

Commit

Permalink
add flag to disable constexpr mutex, see microsoft/STL#4875
Browse files Browse the repository at this point in the history
  • Loading branch information
fakufaku committed Aug 7, 2024
1 parent 332cd39 commit cb03388
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
matrix:
#os: [ubuntu-latest, macos-13, macos-latest, windows-latest]
#python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
os: [windows-2019]
os: [windows-latest]
python-version: [3.8, 3.9]
exclude:
- os: macos-latest
Expand Down Expand Up @@ -41,8 +41,7 @@ jobs:
- name: Test with pytest
run: |
pip install -U pytest setuptools build wheel twine
python ./pyroomacoustics/tests/test_build_rir.py
# pytest
pytest
- name: Test the universal wheels
if: matrix.os == 'ubuntu-latest'
run: |
Expand Down
9 changes: 8 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,14 @@ def __str__(self):
os.path.join(libroom_src_dir, "ext/eigen"),
],
language="c++",
extra_compile_args=["-DEIGEN_MPL2_ONLY", "-Wall", "-O3", "-DEIGEN_NO_DEBUG"],
extra_compile_args=[
"-DEIGEN_MPL2_ONLY",
"-Wall",
"-O3",
"-DEIGEN_NO_DEBUG",
# see https://github.com/microsoft/STL/issues/4875
"-D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR",
],
),
Extension(
"pyroomacoustics.build_rir",
Expand Down

0 comments on commit cb03388

Please sign in to comment.