Add noise objects to create different type of noise #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to have a simple interface to define background noise. We follow the API of
SoundSource
andMicrophoneArray
where objects are added to the room via theadd
method.We add an abastrct object type
Noise
with a unified interface for all types of noise onto the microphone signals after the propagation has been simulated.Here is an example of the type of code we want to have
The current implementation (for white noise only) is an
snr
parameter to thesimulate
method.The implementation is also not very good and has unrequested scaling of the source signals.
Better to have some modular implementation that is extensible by sub-classing the
Noise
class.For that, we will need to change slightly the interface
TODO
Checks
I am still working on this and will update the status
nosetests
orpy.test
at the root of the repo ?Happy PR 😃