Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AppStream metadata #492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Mailaender
Copy link
Contributor

required for #491. https://www.freedesktop.org/software/appstream/docs/ explains what this is about. I didn't count for https://hughsie.github.io/oars/ as the ROMs contain the data and are not shipped with the emulator.

@Mailaender Mailaender mentioned this pull request Aug 29, 2022
7 tasks
@LIJI32
Copy link
Owner

LIJI32 commented Sep 16, 2022

Few questions/notes:

  1. What is the purpose of the new Makefile rule? No target seems to require it so it won't ever be executed and copied over.
  2. Isn't this metadata for repositories themselves? Why would it need to be installed anyway?
  3. <metadata_license>CC0-1.0</metadata_license> is problematic. I didn't license anything in my repo under a CC license
  4. It's better if the screenshots are hosted in-repo rather than some 3rd-party website. They're outdated anyway (0.12.3, old menu background, old menu contents, old boot logo, old color correction)

@Mailaender
Copy link
Contributor Author

Mailaender commented Sep 17, 2022

  1. I was confused by the Makefile structure as I have never seen someone do file based targets. Where do I add it?
  2. https://freedesktop.org/software/appstream/docs/chap-Metadata.html is meant to be for upstream inclusion.
  3. Metadata license is the license for the XML file not your code.
  4. I am also not quite happy about the Ubuntu artwork in the screenshot, as it should be neutral. The ones on your homepage seem to be macOS exclusive, though.

@QuLogic
Copy link

QuLogic commented Nov 1, 2024

I was confused by the Makefile structure as I have never seen someone do file based targets. Where do I add it?

The install target should depend on it, like it does for the icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants