This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
add the kripke #57
Open
mclarsen
wants to merge
216
commits into
develop
Choose a base branch
from
kripke
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add the kripke #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@starintheuniverse Here you go. |
This needs a newer version of raja, so you may have to rebuild some deps. I have found it useful to build with
|
Current In == 0.7658220366 Current Out == 0.7658343481 Current In - Out == -1.231e-05 I.S. quadtree 13 levels, abs_tau_flux == 1.000e-04 size == 76376805 (apprx) Current In == 0.7657741516 (apprx) Current Out == 0.7657625209 (apprx) Current In - Out == 1.163e-05
(store_samples needs to be fixed still)
Set use_eggs=false to try uniform absorption and see that it is preserved to machine precision on all domains.
While per-domain discrepancies are <1e-6, the total metric gives 1e-2. This could indicate a problem with synchronizing shared boundary faces, or it could be that my test is wrong.
Domain[59] excess== 0.00000000068 Domain[60] excess== 0.00000000306 Domain[61] excess==-0.00000000186 Domain[62] excess==-0.00000000186 Domain[63] excess== 0.00000000071 Entire excess== 0.02622323856 leak:1.68e+01 src:1.00e+00 rem:-1.58e+01 cancelling==-0.02622259641 excess+cancelling==6.421469e-07 This shows that, for some reason, the sum over domains of sum_side_current() of the problem-interior domain boundaries is not getting cancelled as it should.
…on and initialization. Now the inflow boundaries have matching received and interpolated-from-received. Conservation discrepancy down from 1e-2 to 6e-7.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.