Feature/error handling just the core #373
Conversation
…recated-code-types
…recated-code-types
…recated-code-types
…ypes' into feature/error-handling-just-the-core
…ypes' into feature/error-handling-just-the-core
…recated-code-types
|
OK, this should be good to go now. I had to disable the GTest unit tests in the Github CI for now as they randomly segfault for an unknown reason that is going to require in depth debugging. The tests pass locally and the address sanitizer does not report any issues. |
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu> Co-authored-by: David Gardner <gardner48@llnl.gov>
Co-authored-by: David Gardner <gardner48@llnl.gov>
…core' into feature/error-handling-just-the-core
|
@gardner48 It seems that your commit adding back the address sanitizer broke the Jenkins CI. It looks like it causes output differences. Is there a reason to add it in this already lengthy PR (was it removed by accident?), or can we add it in a separate PR? |
I only intended to remove the C90 tests before but in looking back over all the changes I noticed that this also removed the sanitizer tests. However, these test were only building the code not running test tests so when adding them back I switched the setup to run the tests but seems to have broken things. I'll revert it to how it was before in a sec. |
Add core error handling functions and macros --------- Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu> Co-authored-by: David J. Gardner <gardner48@llnl.gov>
Rendered docs here: https://sundials.readthedocs.io/en/feature-error-handling-just-the-core/.