Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling in cvode #382

Merged
merged 32 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
2d59639
error handling in cvode
balos1 Dec 6, 2023
631660a
Merge branch 'feature/error-handling-just-the-core-formatted' into fe…
balos1 Dec 6, 2023
fdd7d02
Merge branch 'feature/error-handling-just-the-core-formatted' into fe…
balos1 Dec 7, 2023
055fc4f
Merge branch 'feature/error-handling-just-the-core-formatted' into fe…
balos1 Dec 7, 2023
e6f4902
Apply suggestions from code review
balos1 Dec 7, 2023
eff4012
Merge remote-tracking branch 'origin/feature/error-handling-cvode' in…
balos1 Dec 7, 2023
6ae4831
Merge branch 'feature/error-handling-just-the-core-formatted' into fe…
balos1 Dec 7, 2023
d5757fc
fix cvode.c changes
balos1 Dec 7, 2023
5c5d3c3
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 7, 2023
3ef61b1
add cvode error handling unit test
balos1 Dec 7, 2023
4e2d8dd
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 7, 2023
7174507
Merge branch 'feature/error-handling-just-the-core-formatted' into fe…
balos1 Dec 7, 2023
f4e361e
Merge branch 'feature/error-handling-just-the-core-formatted' into fe…
balos1 Dec 7, 2023
7a0ec4d
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 7, 2023
eec60e6
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 7, 2023
2f46396
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 8, 2023
dd35902
remove cvode error handler function
balos1 Dec 8, 2023
bbf6ff7
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 8, 2023
7c6ba5a
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 8, 2023
8aeede6
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 8, 2023
574d9c1
format after merge
balos1 Dec 8, 2023
f26a776
ensure sundials_mpi_errors.h is included when MPI is enabled
balos1 Dec 8, 2023
3c1635c
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 8, 2023
741b58f
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 11, 2023
03a3033
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 11, 2023
5cf67b9
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 11, 2023
5670a7a
make requested changes
balos1 Dec 11, 2023
329fccb
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 12, 2023
81bf98f
fix cmake for unit test
balos1 Dec 12, 2023
74da510
call GetLastError in ProcessError
balos1 Dec 12, 2023
2871a5a
Merge branch 'feature/error-handling-staging' into feature/error-hand…
balos1 Dec 12, 2023
fc3920d
address comments
balos1 Dec 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions examples/cvode/parallel/cvAdvDiff_diag_p.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@
#include <nvector/nvector_parallel.h> /* access to MPI-parallel N_Vector */
#include <stdio.h>
#include <stdlib.h>
#include <sundials/sundials_logger.h>
#include <sundials/sundials_mpi_errors.h>
#include <sundials/sundials_types.h> /* definition of type realtype */
#include <sundials/sundials_core.h>

/* Problem Constants */

Expand Down Expand Up @@ -128,7 +126,7 @@ int main(int argc, char* argv[])

/* Setup different error handler stack so that we abort after logging */
SUNContext_PopErrHandler(sunctx);
SUNContext_PushErrHandler(sunctx, SUNMPIAbortErrHandlerFn, NULL);
SUNContext_PushErrHandler(sunctx, SUNAbortErrHandlerFn, NULL);
SUNContext_PushErrHandler(sunctx, SUNLogErrHandlerFn, NULL);

/* This requires that SUNDIALS was configured with the CMake options
Expand Down
Loading