Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling in stuff that isnt in the other PRs #392

Merged
merged 16 commits into from
Dec 13, 2023

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Dec 11, 2023

No description provided.

Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments/requests.

@balos1 balos1 requested a review from drreynolds December 12, 2023 08:02
doc/shared/sunmemory/SUNMemory_Description.rst Outdated Show resolved Hide resolved
doc/shared/sunmemory/SUNMemory_CUDA.rst Outdated Show resolved Hide resolved
doc/shared/sunmemory/SUNMemory_HIP.rst Show resolved Hide resolved
src/sunmemory/sycl/sundials_sycl_memory.cpp Outdated Show resolved Hide resolved
src/sunmemory/sycl/sundials_sycl_memory.cpp Outdated Show resolved Hide resolved
src/sunmemory/sycl/sundials_sycl_memory.cpp Show resolved Hide resolved
src/sunmemory/system/sundials_system_memory.c Show resolved Hide resolved
src/sunmemory/system/sundials_system_memory.c Show resolved Hide resolved
src/sunmemory/cuda/sundials_cuda_memory.cu Show resolved Hide resolved
src/sunmemory/hip/sundials_hip_memory.hip.cpp Outdated Show resolved Hide resolved
src/sunmemory/sycl/sundials_sycl_memory.cpp Outdated Show resolved Hide resolved
src/sunmemory/sycl/sundials_sycl_memory.cpp Outdated Show resolved Hide resolved
src/sunmemory/sycl/sundials_sycl_memory.cpp Outdated Show resolved Hide resolved
doc/shared/sunmemory/SUNMemory_CUDA.rst Outdated Show resolved Hide resolved
doc/shared/sunmemory/SUNMemory_Description.rst Outdated Show resolved Hide resolved
doc/shared/sunmemory/SUNMemory_SYCL.rst Outdated Show resolved Hide resolved
src/sunmemory/hip/sundials_hip_memory.hip.cpp Show resolved Hide resolved
src/sunmemory/cuda/sundials_cuda_memory.cu Show resolved Hide resolved
src/sunmemory/cuda/sundials_cuda_memory.cu Outdated Show resolved Hide resolved
src/sunmemory/cuda/sundials_cuda_memory.cu Outdated Show resolved Hide resolved
src/sunmemory/hip/sundials_hip_memory.hip.cpp Show resolved Hide resolved
src/sunmemory/sycl/sundials_sycl_memory.cpp Show resolved Hide resolved
balos1 and others added 2 commits December 13, 2023 11:33
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
@balos1 balos1 requested a review from gardner48 December 13, 2023 21:53
Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor items.

doc/shared/sunmemory/SUNMemory_Description.rst Outdated Show resolved Hide resolved
doc/shared/sunmemory/SUNMemory_SYCL.rst Outdated Show resolved Hide resolved
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
@balos1 balos1 merged commit 2545e03 into feature/error-handling-staging Dec 13, 2023
5 of 13 checks passed
@balos1 balos1 deleted the feature/error-handling-modulo branch December 13, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants