Release/v6.7.0 #399
Closed
Release/v6.7.0 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balos1
requested review from
gardner48,
cswoodward and
drreynolds
as code owners
balos1
force-pushed
the
release/v6.7.0
branch
from
322c392 to
578ec3e
Compare
drreynolds
previously approved these changes
Dec 16, 2023
gardner48
requested changes
Dec 18, 2023
|
I've updated the change log but noticed this PR includes a merge commit with In case we want to use this branch, I've opened a draft PR for it to get the CI going. |
Merged
example_utilities.hpp requires `stoi` and similar methods. These are declared in `<string>`, but `<string>` is not included. This means this file will break any TU it's included in. Resolves #330 Co-authored-by: Cody Balos <balos1@llnl.gov>
Fixes #335 Co-authored-by: David Gardner <gardner48@llnl.gov>
Fixes #333. Some other typedefs already had specialized (towards idas or cvodes) prefixed names, it won't harm to generalize this. --------- Co-authored-by: Cody Balos <balos1@llnl.gov>
Add scripts for comparing benchmark and example timings against release timings and a notebook using Thicket to visualize data --------- Co-authored-by: David J. Gardner <gardner48@llnl.gov> Co-authored-by: Cody J. Balos <balos1@llnl.gov>
Fix missing soversion on some SUNLinSol and SUNNonlinSol targets --------- Signed-off-by: Julien Schueller <schueller@phimeca.com> Co-authored-by: Cody Balos <balos1@llnl.gov>
1. Adds missing implicit tables to the ARKODE constants docs 2. Makes formatting of constants consistent in ARKODE docs 3. Groups implicit tables by order --------- Co-authored-by: David Gardner <gardner48@llnl.gov>
Update ARKStepSetTableNum to recognize ARK2-3-1-2 as a valid ARK pair.
Fixes #339: A regression was introduced by the stop time bug fix in v6.6.1 causing integrators to return at the stop time rather than the requested output time if the stop time was reached in the same step in which the output time was passed. Also fixes a missing check in ARKODE to interpolate (or not) the solution at the stop time.
Fix CVodeQuadSStolerances docs, add CVodeQuadSVtolerances docs (Fixes #340)
Only adding the `Sofroniou-Spaletta-5-3-4` method but not changing the defaults like #345 --------- Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu> Co-authored-by: David Gardner <gardner48@llnl.gov>
This PR adds the ginkgo dpcpp support in the examples: sunmatrix, sunlinsol, and cvode/cv_heat2D I currently only know `queue->wait_and_throw()` to synchronize which requires queue unlike `cudaDeviceSynchronize` or `hipDeviceSynchronize` In sunlinsol and cv_heat2D, some function signatures are also used in other files such that I can not pass an additional parameter. I use global variable to store ginkgo executor and then get the queue when SYCL needs sync or submit the kernel in those functions. --------- Signed-off-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com> Co-authored-by: Cody Balos <balos1@llnl.gov>
Always append hipblas and hipsparse CMake targets with HIP backend as these libraries are not reliably included in the pkgconfig file. Replace cublas and cusparse with the CMake targets because the library path in the pkgconfig file is not reliable. Specifically, the path is wrong on systems using the NVIDIA HPC SDK. --------- Co-authored-by: David Gardner <gardner48@llnl.gov>
Added Fortran support for the LAPACK dense SUNLinearSolver implementation. --------- Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
Additional embedded explicit Runge--Kutta methods to ARKODE. --------- Co-authored-by: Steven Roberts <roberts115@llnl.gov> Co-authored-by: David J. Gardner <gardner48@llnl.gov>
Updated `SUNProfiler` to note rely on `MPI_WTime`. Fixes #312 --------- Co-authored-by: David Gardner <gardner48@llnl.gov>
Fix the description of `ONE_STEP` mode in ARKODE. The solution at the end of the step is always returned and interpolation is not performed.
Upload artifact with just output files so the artifact is smaller --------- Co-authored-by: David Gardner <gardner48@llnl.gov>
Remove unused files from the repo
* Cancel existing workflow on new push * Add dispatch trigger for all actions * Upload all outputs from testing directory --------- Co-authored-by: Cody Balos <cjbalos@gmail.com>
Remove F77 interface examples from `develop` branch. Once this PR is merged, a new `archive` branch can be created for easy reference until #302 is merged and the `archive` branch can be deleted. --------- Co-authored-by: Cody Balos <balos1@llnl.gov>
Simplify tarscript to include directories rather than individual files --------- Co-authored-by: Cody Balos <balos1@llnl.gov>
Fixed a bug in ERKStep where methods with `c[s-1] = 1` but `a[s-1,j] != b[j]` were incorrectly treated as having the first same as last (FSAL) property. Fixed a bug in `MRIStepCoupling_Write` where explicit coupling tables were not written to the output file pointer. ARKStep, ERKStep, MRIStep, and SPRKStep were updated to remove a potentially unnecessary right-hand side evaluation at the end of an integration. ARKStep was additionally updated to remove extra right-hand side evaluations when using an explicit method or an implicit method with an explicit first stage. The `MRIStepInnerStepper` class in MRIStep was updated to make supplying an `MRIStepInnerFullRhsFn` optional. --------- Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu> Co-authored-by: Cody Balos <balos1@llnl.gov>
New object-oriented infrastructure for time step adaptivity controllers. --------- Co-authored-by: David J. Gardner <gardner48@llnl.gov> Co-authored-by: Balos, Cody, J <balos1@llnl.gov> Co-authored-by: Cody Balos <cjbalos@gmail.com>
Add developer docs to RTD superbuild Add instructions for updating answers in the developer docs. --------- Co-authored-by: David Gardner <gardner48@llnl.gov>
Fix table name for the implicit part of 5th order IMEX-ARK methods
Add graphviz to Read the Docs config to display graphviz figures
Abort a running Pipeline build if a new one is started
Fix DIRK table names in IMEX pairs and loop over IMEX table pairs --------- Co-authored-by: Cody Balos <balos1@llnl.gov>
Updated table showing N_Vector requirements from ARKODE. This is in support of some SciDAC partnerships, who are beginning to create custom N_Vector implementations to interface with ARKODE, and who want an up-to-date list of the minimum N_Vector routines they'll need to implement. --------- Co-authored-by: Cody Balos <balos1@llnl.gov>
balos1
force-pushed
the
release/v6.7.0
branch
from
99add15 to
b266176
Compare
|
@gardner48 I rebased this branch and removed the merged commit |
|
Using #401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.