Maintenance/arkode UI #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o start on .c files.
…ific UI routines to wrap those.
drreynolds
requested review from
balos1,
gardner48 and
cswoodward
as code owners
balos1
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Overall, I this looks great and it will make creating a stepper significantly easier. I think most or all of my requests are very minor changes.
I do have a little bit of concern that users will find all of the deprecation messages they are about to get very annoying (if it breaks their builds due to strict treatment of warnings for example), but I suppose there is not really a good way of avoiding that unless we want to support the old functions indefinitely.
I have not made it through every file (in particular the examples), but I looked at all of the main pieces.
…s (void* arkode_mem -> ARKodeMem ark_mem)
gardner48
requested changes
May 4, 2024
doc/arkode/guide/source/Usage/SPRKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: David Gardner <gardner48@llnl.gov>
… maintenance/arkode-ui
gardner48
requested changes
May 6, 2024
doc/arkode/guide/source/Usage/ERKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
|
Revised plan:
|
…e.rst Co-authored-by: David Gardner <gardner48@llnl.gov>
balos1
previously approved these changes
May 6, 2024
gardner48
requested changes
May 6, 2024
gardner48
pushed a commit
to sundials-codes/answers
that referenced
this pull request
May 6, 2024
Update answers for LLNL/sundials#459
gardner48
reviewed
May 6, 2024
gardner48
approved these changes
May 7, 2024
gardner48
added a commit
that referenced
this pull request
Jun 20, 2024
Create a shared UI for all ARKODE steppers. --------- Co-authored-by: Cody Balos <balos1@llnl.gov> Co-authored-by: David Gardner <gardner48@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR, that includes only the code changes to ARKODE to create a shared UI for all steppers. I'm opening this now, in its current form, so that the team can provide feedback.
Remaining items before this is a "final" PR: