Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance/GitHub issues prs templates #478

Merged
merged 8 commits into from
May 15, 2024

Conversation

balos1
Copy link
Member

@balos1 balos1 commented May 15, 2024

Adds templates for issues and PRs. The templates need to be on main to work. After merging this into main we can sync main and develop.

Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor items; otherwise this looks great.

.github/ISSUE_TEMPLATE/general.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE/general.md Outdated Show resolved Hide resolved
@balos1 balos1 requested a review from drreynolds May 15, 2024 17:21
@balos1
Copy link
Member Author

balos1 commented May 15, 2024

You can preview how these templates look here https://github.com/sundials-codes/test-github-templates

drreynolds
drreynolds previously approved these changes May 15, 2024
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor items, otherwise this looks good.

Do we want to merge this to main and rebase develop or put this in develop and have it go into main with the next release?

.github/ISSUE_TEMPLATE/bug.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.md Show resolved Hide resolved
@balos1
Copy link
Member Author

balos1 commented May 15, 2024

@gardner48 Once you approve, this can be merged (Jenkins CI can be bypassed since it only changes these template files).

@gardner48
Copy link
Member

@gardner48 Once you approve, this can be merged (Jenkins CI can be bypassed since it only changes these template files).

Do we want to merge this to main and rebase develop or put this in develop and have it go into main with the next release?

@balos1
Copy link
Member Author

balos1 commented May 15, 2024

I would like it to go into main now and rebase develop so we do not have to wait for the templates to be active.

@gardner48 gardner48 merged commit b685654 into main May 15, 2024
19 of 24 checks passed
@gardner48 gardner48 deleted the maintenance/github-issues-prs-templates branch May 15, 2024 19:28
@gardner48 gardner48 added this to the SUNDIALS Next milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants