Loop over all Butcher tables to test order #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steven-Roberts
requested review from
balos1,
gardner48,
cswoodward and
drreynolds
as code owners
|
Is there any need to do outfile checking for this test? Isn't the return code of the test enough? |
drreynolds
reviewed
May 17, 2024
That's a good question, since I also do not fully understand the use of |
drreynolds
previously approved these changes
May 20, 2024
balos1
approved these changes
May 23, 2024
|
@Steven-Roberts A couple of follow-on items to this PR:
|
Actually, no need to update |
|
Ok, looks like I'll need a separate PR to do that now that this is merged. |
I always forget about this nice sphinx feature |
gardner48
added a commit
that referenced
this pull request
May 24, 2024
Address a couple missing things noted in #488 after it was merged. --------- Co-authored-by: David Gardner <gardner48@llnl.gov>
gardner48
pushed a commit
that referenced
this pull request
Jun 20, 2024
Switches from a vector of table names (which was often not updated) to iterating over the enum of tables so methods get included in this test automatically.
gardner48
added a commit
that referenced
this pull request
Jun 20, 2024
Address a couple missing things noted in #488 after it was merged. --------- Co-authored-by: David Gardner <gardner48@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from a vector of table names (which was often not updated) to iterating over the enum of tables so methods get included in this test automatically.