Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default ARKODE methods #547

Open
wants to merge 60 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
f6ff36d
Update default RK methods by order
Steven-Roberts Jul 26, 2024
198b442
Merge branch 'develop' into feature/rk_defaults
Steven-Roberts Jul 26, 2024
2bc4fb0
Add 5th order ERK of Tsitouras
Steven-Roberts Jul 26, 2024
6acabdc
Add FSAL 2nd order Ralston method
Steven-Roberts Jul 26, 2024
c5aeea6
Add Ralston to table in def file
Steven-Roberts Jul 26, 2024
609abba
Update Fortran interfaces
Steven-Roberts Jul 26, 2024
7dbb7f1
Merge branch 'develop' into feature/rk_defaults
Steven-Roberts Aug 29, 2024
e5df915
Merge branch 'develop' into feature/rk_defaults
Steven-Roberts Sep 6, 2024
1d790fe
Set the default ERKStep methods
Steven-Roberts Sep 6, 2024
4fee262
Update swig
Steven-Roberts Sep 6, 2024
045adb5
Butcher docs fixes
Steven-Roberts Sep 7, 2024
fb02b3e
Add Ralson method to docs
Steven-Roberts Sep 8, 2024
6a9a0ff
Update defaults in docs
Steven-Roberts Sep 8, 2024
f0b32d9
Add new methods to constants
Steven-Roberts Sep 8, 2024
b7518b2
Update changelog
Steven-Roberts Sep 8, 2024
3f015dd
Add Tsitouras method to docs
Steven-Roberts Sep 8, 2024
a22ad08
Update doc/arkode/guide/source/Butcher.rst
Steven-Roberts Sep 10, 2024
d49f254
Merge branch 'develop' into feature/rk_defaults
Steven-Roberts Sep 10, 2024
1fea10b
Merge branch 'develop' into feature/rk_defaults
gardner48 Sep 11, 2024
d61fb37
Apply suggestions from code review
Steven-Roberts Sep 11, 2024
405355c
Remove trailing 0 from table
Steven-Roberts Sep 11, 2024
b625207
Merge branch 'develop' into feature/rk_defaults
Steven-Roberts Sep 16, 2024
5bfc505
Fix number of columns in table
Steven-Roberts Sep 16, 2024
fe2737f
Merge branch 'develop' into feature/rk_defaults
gardner48 Sep 16, 2024
b622b20
Add table of ERK properties
Steven-Roberts Sep 16, 2024
7ef8a2a
Remove ERK constants
Steven-Roberts Sep 16, 2024
9fb8aa9
Merge branch 'feature/rk_defaults' of github.com:LLNL/sundials into f…
Steven-Roberts Sep 16, 2024
4ca3a50
Add DIRK table of properties
Steven-Roberts Sep 17, 2024
bc56b9d
update output files
gardner48 Sep 17, 2024
1660217
Remove MRI constants
Steven-Roberts Sep 17, 2024
f640b9a
Update ERK to use enumerators
Steven-Roberts Sep 17, 2024
d2a3a4a
Update DIRK to use enumerators
Steven-Roberts Sep 17, 2024
3ace173
Merge branch 'feature/rk_defaults' of github.com:LLNL/sundials into f…
Steven-Roberts Sep 17, 2024
9d865f2
Update ARK to use enumerators
Steven-Roberts Sep 17, 2024
a1ec425
Update SPRK to use enumerators
Steven-Roberts Sep 17, 2024
641746e
Fix broken refs
Steven-Roberts Sep 17, 2024
58206dd
Remove old constants
Steven-Roberts Sep 17, 2024
49cabed
Correct types of default tables
Steven-Roberts Sep 18, 2024
6666fe7
Bring back default tables to constants docs
Steven-Roberts Sep 18, 2024
9fefa0d
Revert default table constants to int
Steven-Roberts Sep 25, 2024
872ad0b
Merge branch 'develop' into feature/rk_defaults
Steven-Roberts Sep 25, 2024
3d66641
Merge branch 'develop' into feature/rk_defaults
Steven-Roberts Jan 9, 2025
f433f7e
Add missing whitespace
Steven-Roberts Jan 10, 2025
bab2097
Update single precision files
Steven-Roberts Jan 10, 2025
74bd101
Update additional single precision out file
Steven-Roberts Jan 10, 2025
7149aec
Enable artifacts for logging tests
Steven-Roberts Jan 10, 2025
2987445
Update double precision files
Steven-Roberts Jan 10, 2025
0ac4422
Enable artifacts for logging tests
Steven-Roberts Jan 10, 2025
ffed497
Update logging test out files
Steven-Roberts Jan 10, 2025
f689914
Level 3 logging out files
Steven-Roberts Jan 10, 2025
271ae5b
Level 4 logging out files
Steven-Roberts Jan 10, 2025
5b4a0d4
Final logging out files
Steven-Roberts Jan 10, 2025
34b2666
More out file updates for sanitizer_build_and_test
Steven-Roberts Jan 10, 2025
b5aebc8
Update answers repo
Steven-Roberts Jan 10, 2025
e6cbd0e
Update f2003 out files
Steven-Roberts Jan 11, 2025
caabcfd
update output files
gardner48 Jan 11, 2025
3b75d4b
Fix bug in floatCompare when numbers get rounded differently despite …
Steven-Roberts Jan 11, 2025
a3c9627
Update double precision out files
Steven-Roberts Jan 11, 2025
9247376
Update ark_heat1D_omp.out
Steven-Roberts Jan 12, 2025
2ebbd6e
update fortran output files
gardner48 Jan 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/ubuntu-clang-latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,23 @@ jobs:
--label-regex logging \
--verbose

- name: Archive build files from failed build
uses: actions/upload-artifact@v4
if: failure()
with:
name: build_files
path: |
${{ github.workspace }}/build
!${{ github.workspace }}/build/Testing/output

- name: Archive output files from failed build
uses: actions/upload-artifact@v4
if: failure()
with:
name: output_files
path: |
${{ github.workspace }}/build/Testing/

build_cycle_profiling:
runs-on: ubuntu-latest

Expand All @@ -82,3 +99,20 @@ jobs:
- name: Build
# Build your program with the given configuration
run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}

- name: Archive build files from failed build
uses: actions/upload-artifact@v4
if: failure()
with:
name: build_files
path: |
${{ github.workspace }}/build
!${{ github.workspace }}/build/Testing/output

- name: Archive output files from failed build
uses: actions/upload-artifact@v4
if: failure()
with:
name: output_files
path: |
${{ github.workspace }}/build/Testing/
19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,25 @@

### New Features and Enhancements

Added the `ARKODE_RALSTON_3_1_2` and `ARKODE_TSITOURAS_7_4_5` explicit
Runge-Kutta Butcher tables.

Improved the efficiency of default ARKODE methods with the following changes:

| Type | Old Default | New Default |
| ------------------ | ---------------------------------------------------------------- | ------------------------------------------------------------------ |
| 2nd Order Explicit | `ARKODE_HEUN_EULER_2_1_2` | `ARKODE_RALSTON_3_1_2` |
| 4th Order Explicit | `ARKODE_ZONNEVELD_5_3_4` | `ARKODE_SOFRONIOU_SPALETTA_5_3_4` |
| 5th Order Explicit | `ARKODE_CASH_KARP_6_4_5` | `ARKODE_TSITOURAS_7_4_5` |
| 6th Order Explicit | `ARKODE_VERNER_8_5_6` | `ARKODE_VERNER_9_5_6` |
| 8th Order Explicit | `ARKODE_FEHLBERG_13_7_8` | `ARKODE_VERNER_13_7_8` |
| 2nd Order Implicit | `ARKODE_SDIRK_2_1_2` | `ARKODE_ARK2_DIRK_3_1_2` |
| 3rd Order Implicit | `ARKODE_ARK324L2SA_DIRK_4_2_3` | `ARKODE_ESDIRK325L2SA_5_2_3` |
| 4th Order Implicit | `ARKODE_SDIRK_5_3_4` | `ARKODE_ESDIRK436L2SA_6_3_4` |
| 5th Order Implicit | `ARKODE_ARK548L2SA_DIRK_8_4_5` | `ARKODE_ESDIRK547L2SA2_7_4_5` |
| 4th Order ARK | `ARKODE_ARK436L2SA_ERK_6_3_4` and `ARKODE_ARK436L2SA_DIRK_6_3_4` | `ARKODE_ARK437L2SA_ERK_7_3_4` and `ARKODE_ARK437L2SA_DIRK_7_3_4` |
| 5th Order ARK | `ARKODE_ARK548L2SA_ERK_8_4_5` and `ARKODE_ARK548L2SA_DIRK_8_4_5` | `ARKODE_ARK548L2SAb_ERK_8_4_5` and `ARKODE_ARK548L2SAb_DIRK_8_4_5` |

### Bug Fixes

Fixed bug in the ARKODE SPRKStep `SPRKStepReInit` function and `ARKodeReset` function
Expand Down
Loading
Loading