Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SundialsLapack.cmake: fix undefined print_error() call #570

Closed
wants to merge 1 commit into from

Conversation

valgur
Copy link

@valgur valgur commented Sep 11, 2024

CMake configuration currently fails with

CMake Error at cmake/tpl/SundialsLapack.cmake:41 (print_error):
  Unknown CMake command "print_error".
Call Stack (most recent call first):
  cmake/SundialsSetupTPLs.cmake:122 (include)
  CMakeLists.txt:186 (include)

if ENABLE_LAPACK=TRUE and SUNDIALS_PRECISION=extended.


  • Please target the develop branch not main.
  • Review our Contributing Guide, and ensure that you sign your last commit (at minimum) as per the guide.
  • Provide a concise description of what your pull request does, and why it is needed/benefical.
  • Add a note about your change to the CHANGELOG.md and docs/shared/RecentChanges.rst files. Notice that the former is a markdown file and the latter is reStructuredText, so the formatting is slightly different.
  • After your PR is opened, ensure that all of the tests are passing (a SUNDIALS developer will have to allow the testing to run).

Signed-off-by: Martin Valgur <martin.valgur@gmail.com>
@balos1
Copy link
Member

balos1 commented Sep 11, 2024

This is fixed by #542.

@balos1 balos1 closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants