Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes/enhancements to FollowReference/UAV #206

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

krisgry
Copy link
Contributor

@krisgry krisgry commented Aug 6, 2019

9d0a5e3 fixes what seems to be a typo (&& instead of ||)

f41de2d reorders signalError and a dispatch, as the message was never dispatched

The two other commits are more of a design question, I guess, but the current master code is ambigous:

  • currently, we are waiting for a FollowReference message, and are not accepting any other messages.
  • once the FollowReference is activated, the first DesiredPath is dispatched. But since we have not received any EstimatedState or Reference yet, lat/lon/height is zero.

There are two ways to fix this:

  1. always consume EstimatedState (9233527). Then, upon FollowReference activation, the current position is dispatched as lat/lon/height. This is in my eyes less than ideal, which is why I suggest
  2. always consume EstimatedState and Reference (9233527 and b59f972). Store Reference as it is received. Upon FollowReference activation, check if the previous Reference came from an authorized source. If it did; use it, if not; use EstimatedState.

Tested in flight

krisgry added 4 commits August 6, 2019 20:29
Is needed upon consume FollowReference
EstimatedState if not received Reference
This fixes a bug where the reference would jump to the current position
at the start of a FollowReference Maneuver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant