Miscellaneous small CSS changes #3348
Open
+15
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed this in 6969d1e
We don't need to resolve these at this point, and we already don't do so for lengths, so leave them in their calc() form until they're used.
Using the raw value meant that 1em would be incorrectly treated as 1px, for example.
All the code here was removed in commit c282138
`<flex-percentage>` is not a thing.
Saves us a round-trip to CSSPixels and back when we already have a double value.
gmta
reviewed
Jan 23, 2025
|
|
||
| float radius = 0.0f; | ||
| if (drop_shadow.radius.has_value()) { | ||
| radius = drop_shadow.radius->resolved(resolution_context).raw_value(); | ||
| radius = static_cast<float>(drop_shadow.radius->resolved(resolution_context).to_px(resolution_context)); |
There was a problem hiding this comment.
Is there a WPT test we can import for this? Somewhere in html/canvas/element/filters perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little things found while working on calc() simplification.