Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Blocking call to open inside the event loop (#167) #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Blocking call to open inside the event loop (#167) #168

wants to merge 1 commit into from

Conversation

Taraman17
Copy link

This encaspulates the problematic call in async_add_executor_job() to fix this issue.

@elupus
Copy link

elupus commented Aug 1, 2024

Fixes #167

elupus
elupus approved these changes Aug 1, 2024
View reviewed changes
Copy link

@elupus elupus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiriBalcar JiriBalcar JiriBalcar approved these changes

@elupus elupus elupus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taraman17 @elupus @JiriBalcar