[Quest] Convert Scattered into Shadow to IF

[jamesbradleym]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Converts Beast AF2 Quest (Scattered into Shadow) to IF/Cleans up npc luas
Implements Tehbi hiding TODO

Capture

Steps to test these changes

Complete Beast AF2 Quest

Notes

• There are 2 dialogs given by Brutus depending on whether or not you had previously declined the quest. So, first time -> long dialog, second time post decline -> short dialog.
• The CS/event for each of the flora removals delivers the removal message
• Tehbi disappears for 15 mins on successful beast collar trade
• The Beast Collar is retrieved from a chest in CASTLE_OZTROJA thus we need to retrieve the quest var, Prog from outside the quest lua - there's a deprecated method in utils.lua (utils.getQuestVar) which effectively does the same as the code I've updated in treasure.lua for this quest. The deprecation comment says to use xi.quest methods but from my understanding you wouldn't be able to reach these methods without a quest so I've just left it implemented in place.
• Previous PR: [Quest] Convert (Beastmaster AF2) Scattered into Shadow to IF #6102

[hookstar]

Interesting - I had not seen this used except for rycharde in a discussion and in the commands folder... can we enum that? player:getCharVar(Quest.getVarPrefix(JEUNO, SCATTERED_INTO_SHADOW ) .. 'Prog') == 4
for readability? Would be cool if it did the db would be something like
Quest[Jeuno][Scattered_Into_Wind]Prog 4 -- would make finding the quests in the db a lot easier!
below is a case already here to hit the db for CharVar. Hope that helps.

[hookstar]

https://github.com/LandSandBoat/server/blob/base/scripts/globals/treasure.lua#L526

[hookstar]

local pathNodes =
{
    { x = -136.0000, y = 24.2500, z = -21.0000 },
    { x = -140.0788, y = 24.2500, z = -25.9524 },
    { x = -140.1171, y = 24.2500, z = -37.6438 },
    { x = -140.1195, y = 24.2500, z = -45.9640 },
    { x = -140.1225, y = 24.2500, z = -55.6002 },
}

entity.onSpawn = function(npc)
    npc:initNpcAi()
    npc:setPos(xi.path.first(pathNodes))
    npc:pathThrough(pathNodes, xi.path.flag.PATROL)
end

[hookstar]

Those were the captures I took for his pathing - he just runs back and forth -- I have the video somewhere if you'd like it?

[jamesbradleym]

Yeah that would be great to have as reference

[hookstar]

Well, apparently I do not have it uploaded to the hxicaptures youtube...