Cleanup/moving primitive roots to consts #38

anupsv · 2025-01-12T03:43:59Z

Moving primitive roots from a function to consts in [u64; 4] from the bigint form
Adding test to check the conversion from bigint form to reading u256 in str form to ensure correctness.
Addresses: Move primitive roots of unities to constant declaration #31

… needed

…tion_form

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>

…call methods.

src/consts.rs

src/helpers.rs

tests/kzg_test.rs

src/helpers.rs

bxue-l2

Overall LGTM. please address sam PR

samlaf

You'll need to fix the formattng for ci to pass as well

src/consts.rs

src/helpers.rs

src/kzg.rs

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>

samlaf · 2025-01-19T17:41:25Z

@anupsv need to fix the conflicts here after I merged #40

asv and others added 30 commits January 4, 2025 06:13

adding bare changes for batch verification

55a5bf0

adding some comments

259f6b0

adding more comments

4c4bdd0

moving back to sha2

4ecd566

removing a test which is no longer needed. Removing methods no longer…

cb75b3b

… needed

updates to method visibility, updating tests

42bc913

merging main

f3dd7f4

fmt fixes

02fa7ca

clean up

0807ce0

cleanup, optimization, inline docs

da5e5ad

removing unwanted const

b58174b

more docs and cleanup

c1c2f70

formatting

fa02398

removing unwanted comments

914e059

merging main

c74accf

cargo fmt and clippy

f054c19

adding test for point at infinity

90b3d13

cleaner errors, cleanup

486f7da

adding another test case

32716fe

removing unwanted errors

73bc809

adding fixes per comments

618e098

adding 4844 spec references

f7eb705

comment fixes

61e1744

formatting, adding index out of bound check, removing print statement

1c2a79d

removing unwanted test, adding test for evaluate_polynomial_in_evalua…

baf5a44

…tion_form

moving test to bottom section

aa1ded9

Update src/polynomial.rs

86ceab3

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>

Update src/kzg.rs

d67adec

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>

Update src/kzg.rs

02194ba

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>

Update src/kzg.rs

bfd2fac

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>

anupsv added 7 commits January 10, 2025 12:56

adding to_byte_array arg explanation

f9bb219

fmt fixes

5f9fa77

fmt and clippy fixes

cdeae7c

fixing function names and fmt

0624dc6

clippy fixes

c6f0bdd

moving primitive root to consts, adding helper function and changing …

42c328b

…call methods.

merge main and cleanup

3633bc5

anupsv requested review from bxue-l2 and samlaf January 12, 2025 03:45

samlaf reviewed Jan 12, 2025

View reviewed changes

src/consts.rs Outdated Show resolved Hide resolved

src/helpers.rs Outdated Show resolved Hide resolved

tests/kzg_test.rs Outdated Show resolved Hide resolved

tests/kzg_test.rs Show resolved Hide resolved

src/helpers.rs Outdated Show resolved Hide resolved

bxue-l2 reviewed Jan 13, 2025

View reviewed changes

anupsv added 5 commits January 14, 2025 06:03

Merge branch 'master' into cleanup/moving-primitive-roots-to-consts

61d719a

removing function

7122430

wrong branch updated

ab22fa2

removing is_zero

955dea8

comment updates

d1621a0

anupsv mentioned this pull request Jan 14, 2025

Cleanup/roots of unities setup functions #37

Merged

anupsv added 3 commits January 14, 2025 12:17

using macro for roots consts

e40ec08

merge master

3d644d3

adding explanation to PRIMITIVE_ROOTS_OF_UNITY

b3d7c1e

samlaf reviewed Jan 16, 2025

View reviewed changes

src/consts.rs Outdated Show resolved Hide resolved

src/helpers.rs Outdated Show resolved Hide resolved

src/kzg.rs Outdated Show resolved Hide resolved

anupsv and others added 3 commits January 16, 2025 14:08

Update src/kzg.rs

641e7b0

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>

Update src/helpers.rs

a327933

Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>

comment change, renames and doc fixes

a3d7767

samlaf approved these changes Jan 19, 2025

View reviewed changes

anupsv added 2 commits January 22, 2025 17:31

merge master

d43d004

cargo fmt

f4b224f

anupsv merged commit ff437c9 into master Jan 23, 2025
1 check passed

anupsv deleted the cleanup/moving-primitive-roots-to-consts branch January 23, 2025 01:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup/moving primitive roots to consts #38

Cleanup/moving primitive roots to consts #38

anupsv commented Jan 12, 2025 •

edited

Loading

bxue-l2 left a comment •

edited

Loading

samlaf left a comment

samlaf commented Jan 19, 2025

Cleanup/moving primitive roots to consts #38

Cleanup/moving primitive roots to consts #38

Conversation

anupsv commented Jan 12, 2025 • edited Loading

bxue-l2 left a comment • edited Loading

Choose a reason for hiding this comment

samlaf left a comment

Choose a reason for hiding this comment

samlaf commented Jan 19, 2025

anupsv commented Jan 12, 2025 •

edited

Loading

bxue-l2 left a comment •

edited

Loading