feat: Scan & device accounts - add account v2 #8802

themooneer · 2025-01-03T17:04:09Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- ...

📝 Description

In the current feature:

After asset selection (crypto + network) , user will be redirected to device selection (with autoSkip and select the current connecting device same as Receive flow).
Once device is wired -> A scan of accounts process starts.
Accounts are displayed 1 by 1 (with a first version of animation).
User can stop the scan process if not finished.
User can select one-to-many accounts via checkbox / select all
User can rename an account (same ui of Add account v1)
Once selection is done a redirection to a UNCOMPLETE SUCCESS SCREEN (will be done LIVE-13983)
For this stage only funded accounts can be added , no warning screen/ui (LIVE-13983 scope)

📹 Videos

selectAccTest1.mov

Notes ‼️

I will add more video related to funded importable accounts which i don't possess on my seed actually.
This won't prevent the PR from being reviewed or even tested if you have a device with multiple accounts for a single currency.

❓ Context

JIRA or GitHub link:
https://ledgerhq.atlassian.net/browse/LIVE-15524

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2025-01-03T17:04:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Jan 15, 2025 3:32pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jan 15, 2025 3:32pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jan 15, 2025 3:32pm
web-tools	⬜️ Ignored (Inspect)	Visit Preview	Jan 15, 2025 3:32pm

live-github-bot · 2025-01-03T17:32:22Z

Mobile Bundle Checks

Comparing b2385a6 against 04af7d7.

✅ Previous issues have all been fixed.

mcayuelas-ledger · 2025-01-08T14:13:05Z

apps/ledger-live-mobile/src/components/SelectableAccountsList.tsx

@@ -28,6 +28,10 @@ import TouchHintCircle from "./TouchHintCircle";
 import Touchable from "./Touchable";
 import { AccountSettingsNavigatorParamList } from "./RootNavigator/types/AccountSettingsNavigator";
 import { AddAccountsNavigatorParamList } from "./RootNavigator/types/AddAccountsNavigator";
+import AccountItem from "~/newArch/features/Accounts/components/AccountsListView/components/AccountItem";


mcayuelas-ledger · 2025-01-08T14:14:31Z

apps/ledger-live-mobile/src/icons/PauseCircle.tsx

We don't have it in DS?

no https://www.figma.com/design/4ZD0Q8lAdv9Bcd7iiW6Cnk/%E2%AD%90-Icons?node-id=3163-105&t=QIV3IweeNqVGCpwx-4

If we're going to use the same icon for the LLD add account can we add it to the DS please ? I don't know if this doc is up to date

I'll do it in a separate ticket once needed by LLD.

mcayuelas-ledger · 2025-01-08T14:15:15Z

apps/ledger-live-mobile/src/locales/en/common.json

+      "scanningTitle": "Looking for any existing accounts on the Blockchain...",
+      "sections": {
+        "importable": {
+          "title": "We found {{count}} account"


it needs plural

mcayuelas-ledger · 2025-01-08T14:15:58Z

apps/ledger-live-mobile/src/locales/en/common.json

@@ -4002,6 +4002,8 @@
      "desc": "Are you sure you want to cancel adding accounts?"
    },
    "imported": "Asset added successfully",
+    "added": "Account added to your portfolio",
+    "added_plural": "{{count}} Accounts added to your portfolio",


Suggested change

"added_plural": "{{count}} Accounts added to your portfolio",

"added_plural": "{{count}} accounts added to your portfolio",

I'm not sure but should be lowercase imo

it's for the success screen , in figma it's uppercase

mcayuelas-ledger · 2025-01-08T14:16:44Z

apps/ledger-live-mobile/src/locales/en/common.json

+          "title": "Accounts already in the Portfolio ({{length}})"
+        },
+        "migrate": {
+          "title": "Accounts to update"


should be singular also no?

no idea about this one, as i'm using the exact same wording of add account v1 , see the same object above

as there is no count there , i prefer leave it like add account v1 wording

mcayuelas-ledger · 2025-01-08T14:21:58Z

...newArch/features/Accounts/screens/ScanDeviceAccounts/components/AddressTypeTooltip/index.tsx

+import Button from "~/components/Button";
+import LText from "~/components/LText";


Same here better to use DS

good to know, i'll do it

mcayuelas-ledger · 2025-01-08T14:22:32Z

...newArch/features/Accounts/screens/ScanDeviceAccounts/components/AddressTypeTooltip/index.tsx

+import ExternalLink from "~/icons/ExternalLink";
+import Info from "~/icons/Info";


those also, if they are available :)

good to know ! (well while i'm using the same as this component apps/ledger-live-mobile/src/screens/AddAccounts/03-Accounts.tsx , i didn't knew that ) thanks

mcayuelas-ledger · 2025-01-08T14:26:06Z

apps/ledger-live-mobile/src/newArch/features/Accounts/screens/ScanDeviceAccounts/index.tsx


+import { accountsSelector } from "~/reducers/accounts";
+import { blacklistedTokenIdsSelector } from "~/reducers/settings";
+import { Theme, withTheme } from "../../../../../colors";


from "styled-components/native"; ?

mcayuelas-ledger · 2025-01-08T14:26:53Z

apps/ledger-live-mobile/src/newArch/features/Accounts/screens/ScanDeviceAccounts/index.tsx

 import Button from "~/components/Button";
 import PreventNativeBack from "~/components/PreventNativeBack";
+import Chevron from "~/icons/Chevron";
 import LText from "~/components/LText";


can you replace this by as you use it already? :)

I know it's not the scope but could be good !

mcayuelas-ledger · 2025-01-08T14:29:00Z

apps/ledger-live-mobile/src/newArch/features/AssetSelection/screens/SelectNetwork/index.tsx

@@ -43,7 +43,7 @@ export default function SelectNetwork({
        onPress={onPressItem}
        subTitle={
          item.accounts.length > 0
-            ? t("transfer.receive.selectNetwork.account", { count: item.accounts.length })


if not used anymore could you remove it from common.json?

it's used in the receive flow

cgrellard-ledger · 2025-01-14T12:39:47Z

apps/ledger-live-mobile/src/newArch/features/Accounts/screens/AddAccount/types.ts

+    inline?: boolean;
+    returnToSwap?: boolean;
+    onSuccess?: (res: { scannedAccounts: Account[]; selected: Account[] }) => void;
+  };
  [ScreenName.SelectAccounts]: CommonParams & {
    currency: CryptoCurrency | TokenCurrency;


Suggested change

currency: CryptoCurrency | TokenCurrency;

currency: CryptoOrTokenCurrency;

cgrellard-ledger · 2025-01-14T12:40:09Z

apps/ledger-live-mobile/src/newArch/features/Accounts/screens/AddAccount/types.ts

 import { ScreenName } from "~/const";
 import { Device } from "@ledgerhq/types-devices";
+import { AccountLikeEnhanced } from "../ScanDeviceAccounts/types";
+import { Account } from "@ledgerhq/types-live";
+import { CryptoCurrency, TokenCurrency } from "@ledgerhq/types-cryptoassets";


Suggested change

import { CryptoCurrency, TokenCurrency } from "@ledgerhq/types-cryptoassets";

cgrellard-ledger · 2025-01-14T12:44:11Z

apps/ledger-live-mobile/src/components/SelectableAccountsList.tsx

-    });
-  }, [account, navigation, onAccountNameChange]);
+    if (llmNetworkBasedAddAccountFlow?.enabled) {
+      (navigation as StackNavigationProp<AccountSettingsNavigatorParamList>).navigate(


Do we need this type assertion here ? Is there a way to avoid it ? We should avoid using type assertions as much as possible as they can introduce nasty and hard to debug errors

cgrellard-ledger · 2025-01-14T12:44:19Z

apps/ledger-live-mobile/src/components/SelectableAccountsList.tsx

+          padding="8px"
+          columnGap={8}
+        >
+          <AccountItem account={account as Account} balance={account.spendableBalance} />


…o a maximum useEffect issues

github-actions bot assigned themooneer Jan 3, 2025

live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jan 3, 2025

themooneer force-pushed the feat/LIVE-15524 branch 2 times, most recently from 1bd5924 to 7788db9 Compare January 3, 2025 17:14

themooneer force-pushed the feat/LIVE-15524 branch 11 times, most recently from 1ea3840 to 9dde117 Compare January 8, 2025 14:08

themooneer marked this pull request as ready for review January 8, 2025 14:09

themooneer requested a review from a team as a code owner January 8, 2025 14:09

mcayuelas-ledger reviewed Jan 8, 2025

View reviewed changes

themooneer force-pushed the feat/LIVE-15524 branch 3 times, most recently from 2376268 to c83b9ac Compare January 8, 2025 15:48

themooneer requested a review from mcayuelas-ledger January 9, 2025 09:50

themooneer force-pushed the feat/LIVE-15524 branch from c83b9ac to 240d981 Compare January 10, 2025 17:46

themooneer added 4 commits January 13, 2025 17:18

feat: Scan & device accounts - add account v2

3a3ed21

move lottie.json animation to a common animation directory

b6be724

clean unimported

7d46809

edit code reviews

7e50827

themooneer force-pushed the feat/LIVE-15524 branch from 240d981 to 7e50827 Compare January 13, 2025 16:18

cgrellard-ledger reviewed Jan 14, 2025

View reviewed changes

edit come reviews

990c6bb

themooneer requested a review from cgrellard-ledger January 15, 2025 08:59

cgrellard-ledger previously approved these changes Jan 15, 2025

View reviewed changes

mcayuelas-ledger previously approved these changes Jan 15, 2025

View reviewed changes

fix uncontrolled useEffect due to onSelectAll dependency which lead t…

fab2226

…o a maximum useEffect issues

themooneer dismissed stale reviews from mcayuelas-ledger and cgrellard-ledger via fab2226 January 15, 2025 15:28

cgrellard-ledger approved these changes Jan 15, 2025

View reviewed changes

themooneer merged commit b447baf into develop Jan 15, 2025
40 of 41 checks passed

themooneer deleted the feat/LIVE-15524 branch January 15, 2025 16:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Scan & device accounts - add account v2 #8802

feat: Scan & device accounts - add account v2 #8802

themooneer commented Jan 3, 2025 •

edited

Loading

vercel bot commented Jan 3, 2025 •

edited

Loading

live-github-bot bot commented Jan 3, 2025 •

edited

Loading

mcayuelas-ledger Jan 8, 2025

themooneer Jan 8, 2025

mcayuelas-ledger Jan 8, 2025

themooneer Jan 8, 2025

cgrellard-ledger Jan 14, 2025

themooneer Jan 14, 2025

mcayuelas-ledger Jan 8, 2025

themooneer Jan 8, 2025

mcayuelas-ledger Jan 8, 2025

themooneer Jan 8, 2025

mcayuelas-ledger Jan 8, 2025

themooneer Jan 8, 2025

themooneer Jan 8, 2025

mcayuelas-ledger Jan 8, 2025

themooneer Jan 8, 2025

themooneer Jan 8, 2025

mcayuelas-ledger Jan 8, 2025

themooneer Jan 8, 2025

themooneer Jan 8, 2025

mcayuelas-ledger Jan 8, 2025

themooneer Jan 8, 2025

mcayuelas-ledger Jan 8, 2025

themooneer Jan 8, 2025

mcayuelas-ledger Jan 8, 2025

themooneer Jan 8, 2025

cgrellard-ledger Jan 14, 2025

themooneer Jan 15, 2025

cgrellard-ledger Jan 14, 2025

themooneer Jan 15, 2025

cgrellard-ledger Jan 14, 2025

cgrellard-ledger Jan 14, 2025

themooneer Jan 15, 2025

	"added_plural": "{{count}} Accounts added to your portfolio",
	"added_plural": "{{count}} accounts added to your portfolio",

		import Button from "~/components/Button";
		import LText from "~/components/LText";

		import ExternalLink from "~/icons/ExternalLink";
		import Info from "~/icons/Info";

	currency: CryptoCurrency \| TokenCurrency;
	currency: CryptoOrTokenCurrency;

feat: Scan & device accounts - add account v2 #8802

feat: Scan & device accounts - add account v2 #8802

Conversation

themooneer commented Jan 3, 2025 • edited Loading

✅ Checklist

📝 Description

📹 Videos

Notes ‼️

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Jan 3, 2025 • edited Loading

live-github-bot bot commented Jan 3, 2025 • edited Loading

Mobile Bundle Checks

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

themooneer commented Jan 3, 2025 •

edited

Loading

vercel bot commented Jan 3, 2025 •

edited

Loading

live-github-bot bot commented Jan 3, 2025 •

edited

Loading