Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aptos): remove unknown aptos #8820

Draft
wants to merge 107 commits into
base: develop
Choose a base branch
from

Conversation

jccguimaraes
Copy link
Member

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Removes unneeded operation type UNKNOWN and comment for // APTOS as well

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Vladyslav Belyokhin and others added 30 commits March 6, 2023 20:04
* Add currency
* Add JS Bindings
* Add 'getAddress'
* TODO: Accounts, Send
* Accounts synchronization
* Recieve
* Send
TODO:
* Implement additional settings for token sending
* Gas fee (gas price, gas limit)
* Additional settings (sequence number, exp. timestamp)
* TODO: add texts to the dictionary
- Get transactions from the indexer by its version
- Get both transaction types Receive/Send
- Use Aptos API
semeano and others added 12 commits January 3, 2025 10:02
* WIP: ledger-live boilerplate
* Add currency
* Add JS Bindings
* Add 'getAddress'
* TODO: Accounts, Send

* Implement base functionality for aptos
* Accounts synchronization
* Recieve
* Send
TODO:
* Implement additional settings for token sending

* Add transaction configuration
* Gas fee (gas price, gas limit)
* Additional settings (sequence number, exp. timestamp)
* TODO: add texts to the dictionary

* Fix issues

* Update dictionary

* update `hw-app-aptos` package

* Rework transaction receiving
- Get transactions from the indexer by its version
- Get both transaction types Receive/Send
- Use Aptos API

* Fix dependencies

* LLD small fixes

* Implement Aptos in LLM

* Change transaction praparation, update operation signing

* Update `pnpm-lock.yaml` after merge with `develop`

* Calculate staked balance; display balance on account page

* Rename `xpub` field to `publicKey`

* Remove unused field

* Fix staked amount

* Fix delegation dictionary

* Move `compareAddress` helper from `utils` to `logic`

* Rename `delegatedBalance` to `delegatedAmount`

* Fix typo in dictionary

* Use mainnet

* Revert "Rename `xpub` field to `publicKey`"

This reverts commit 3e2d8d8.

* Handle the case when account's field `freshAddresses` is empty

* Get public key from account id if it can not be retrieved from the device

* Fix condition with xpub

* Implement `getStake` function to calculate stake rewards

* Use testnet endpoint if testnet selected

* Change transaction `function`; add value to `type_arguments`

* Fix bug with the `recepient` field

* Revert "Change transaction `function`; add value to `type_arguments`"

This reverts commit 00b2ab0.

* Remove redundant translations

* Add Aptos to CLI app

* Add changeset

* Fix linter and types problems

* Remove redundant dependency

* support/fix pnpm-lock.yaml after merge conflict

* support(aptos): update pnpm-lock.yaml after merge conflict

* feat(aptos): update transfer function

* fix rebase issues

* fix remaining getAccountUnit imports

* hw-app-aptos.js moved to lib/ledgerjs/packages/hw-app-aptos. Test file has been copied, but is still not active.

* Repurposed README.md from algorand. removed some unused dependencies from the package.

* Small cosmetic changes.

* Managed to make tests work.

* Aptos fixing: History isn't full (#8512)

extending tx to ops with delegation batches and events

* fix(aptos): amount balance (#8462)

* Removing Delegated Balance from the Aptos Footer.

* Prettify addition.

* Removing unecessary code.

* Removing uneeded imports

* Fixing prettier issues.

* Removing the footer and the translation units.

* feat(aptos): add coin feature flag (#8498)

* feat(aptos): add coin feature flag

* feat(aptos): add coin feature flag for testnet

* Removing fees from LLD

* Feedback from PR.

* Removed the custom fees from Ledger Live Mobile.

* Removed a few files that are not needed after the custom fees removal.

* fix(aptos): remove inexistent dependency (#8644)

* Removing unused imports.

* Feat/live 15120 aptos bst fix fees visibility for unparsed transaction (#8618)

* Implement generalised parsing of aptos transactions + logic unit tests

* feat(aptos): update aptos package (#8661)

* feat(aptos): replace deprecated aptos package

* feat(aptos): update aptos types

* chore: update aptos api

* feat(aptos): update aptos package

* feat(aptos): update aptos package

* fix(aptos): get network and indexer api url from network

* fix(aptos): account address issues

* refactor: set private methods

* refactor: build transaction module and api

* refactor: fix logic and constants

* fix: set aptos client with our url paths.

* test: fix imports from old package

* fix: payload type

* fix: logic code and tests

* [QAA] adding Aptos send test (#8450)

* test: adding aptos e2e send test

* feat(aptos): send test

* feat(aptos): uncomment previous tests

* Aptos fixing: History isn't full (#8512)

extending tx to ops with delegation batches and events

* fix(aptos): amount balance (#8462)

* Removing Delegated Balance from the Aptos Footer.

* Prettify addition.

* Removing unecessary code.

* Removing uneeded imports

* Fixing prettier issues.

* Removing the footer and the translation units.

* feat(aptos): add coin feature flag (#8498)

* feat(aptos): add coin feature flag

* feat(aptos): add coin feature flag for testnet

* hw-app-aptos.js moved to lib/ledgerjs/packages/hw-app-aptos. Test file has been copied, but is still not active.

* Repurposed README.md from algorand. removed some unused dependencies from the package.

* Small cosmetic changes.

* Managed to make tests work.

* Feedback from PR.

* chore: add xray ticket id

---------

Co-authored-by: Pedro Semeano <semeano@gmail.com>
Co-authored-by: Oleksii <omblinda@gmail.com>
Co-authored-by: JoΓ£o Martins <63311271+joaoccmartins@users.noreply.github.com>
Co-authored-by: JoΓ£o GuimarΓ£es <jccguimaraes@users.noreply.github.com>
Co-authored-by: JoΓ£o Martins <joaomartinsfcup@gmail.com>

* Fix transaction parsing, after removing sender form aptos input argument (#8691)

* fix(aptos): add amount validation (#8481)

* test(aptos): Unit tests for Aptos API (#8693)

* chore: save work

* chore: save work

* test: index api

* Added a test file for the LedgerAccount based on Jest.

* Feat/live 15457 aptos send receive verify get max send balance logic (#8725)

Fix logic for getMaxSendBalance to use hardcoded values

* chore: update dependencies

* Removed additional settings from Ledger Live Desktop.

* fix merge issues

* feat: add aptos bot tests (#8598)

* feat: add aptos bot testing
---------

Co-authored-by: Samy RABAH-MONTAROU <samy.rabah-montarou@ledger.fr>

* feat(aptos): update node and indexer endpoints (#8773)

feat: update aptos endpoints

* test(aptos): bridge integration tests (#8721)

* test: bridge integration test for aptos

* test: bridge integration test for aptos working

* test: disabled flaky test

* test: create new snapshot

* docs: add comment to flaky test

* test: update to frozen accounts

* test: update to frozen accounts

* fix: remove commented import

* fix: change expireTimestamp to milliseconds

* fix: remove comments

* fix: remove testSignedOperation

* test: add burn address

* test: debugging ci via console log

* chore: remove console logs

* test: fix estimateMaxSpendable assertion

* fix: add missing import

* fix: add missing import

* fix: add burn address for aptos testnet

* fix: prettier rule

* fix: remove unused files

* fix: abandon addresses

* fix: dependencies

* fix: update burn address

* fix: resolver

* chore: undo changes to pnpm-lock file

* fix: imports

* Feat/live 15540 aptos send receive fix when send max is toggled on the amount sent is different in ll and device (#8763)

* Fix the transaction amount that is sent to the device for signing
* remove Gas buffer for maxGasAmount

* chore: save work

* wip generate transaction test

* test: add unit tests for generate transaction

* chore: save work

* test: unit tests for index api

---------

Co-authored-by: Vladyslav Belyokhin <vladyslav.belyokhin@tradoveb2b.com>
Co-authored-by: Vladyslav Belyokhin <belyokhin@gmail.com>
Co-authored-by: Vladyslav Makarian <vladmakaryan@gmail.com>
Co-authored-by: Hedi EDELBLOUTE <hedi.edelbloute@gmail.com>
Co-authored-by: JoΓ£o Martins <joaomartinsfcup@gmail.com>
Co-authored-by: Oleksii <omblinda@gmail.com>
Co-authored-by: JoΓ£o Martins <63311271+joaoccmartins@users.noreply.github.com>
Co-authored-by: JoΓ£o GuimarΓ£es <jccguimaraes@users.noreply.github.com>
Co-authored-by: Victor <162306106+VicAlbr@users.noreply.github.com>
Co-authored-by: JoΓ£o GuimarΓ£es <joao.guimaraes-ext@ledger.fr>
Co-authored-by: Samy RABAH-MONTAROU <samy.rabah-montarou@ledger.fr>
* test(aptos): improve unit tests
* fix: add enhancements and corrections
* test(aptos): improve unit tests
* chore: save work

* chore: save work

* chore: undo bridge integration test move

* fix: import paths

* test: synchronisation tests

* test: synchronisation tests

* test: synchronisation tests

* test: synchronisation tests

* fix: remove jest config

* fix: remove jest config
* fix: transfer type label

* chore: undo organized imports
* test(aptos): improve unit tests
@jccguimaraes jccguimaraes requested review from a team as code owners January 6, 2025 16:23
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 6, 2025 5:09pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 5:09pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 5:09pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 5:09pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools translations Translation files have been touched cli labels Jan 6, 2025
@jccguimaraes jccguimaraes marked this pull request as draft January 6, 2025 16:24
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 6, 2025

Desktop Bundle Checks

Comparing 4eff93d against 2ea3206.

⚠️ renderer bundle size significantly increased: 36.7mb -> 37.8mb. Please check if this is expected.

Mobile Bundle Checks

Comparing 4eff93d against cfce7d9.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM tools Has changes in tools translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants