Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coin-Module] Fix XRP pagination issue #8834

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Coin-Module] Fix XRP pagination issue #8834

wants to merge 1 commit into from
+157 −39

Conversation

jprudent
Copy link

@jprudent jprudent commented Jan 7, 2025 •
edited
Loading

Follow up of @ae713b20c1da18ef33beb730f41fb3ea2990e44

Fix 2 issues:

  1. gracefully handle case where no results are returned (npe)
  2. iterate properly over pages (some txs were skipped)

Refactored the code to be a bit less mutable.

@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools 🛑 Canceled (Inspect) Jan 10, 2025 4:40pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 4:40pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 4:40pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 4:40pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools automation CI/CD stuff translations Translation files have been touched cli labels Jan 7, 2025
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Jan 7, 2025 •
edited
Loading

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@jprudent jprudent changed the base branch from main to develop January 7, 2025 14:27
@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools automation CI/CD stuff translations Translation files have been touched cli labels Jan 7, 2025
@jprudent jprudent changed the title fix pagination issues [ALPACA] Fix pagination issue Jan 7, 2025
@jprudent jprudent force-pushed the fix_pagination_issues branch from 0d055e4 to 9cd95d6 Compare January 9, 2025 12:40
@jprudent jprudent force-pushed the fix_pagination_issues branch from 9cd95d6 to 2163408 Compare January 9, 2025 12:45
@jprudent jprudent marked this pull request as ready for review January 9, 2025 12:46
@jprudent jprudent requested a review from a team as a code owner January 9, 2025 12:46
@jprudent jprudent changed the title [ALPACA] Fix pagination issue [ALPACA] Fix XRP pagination issue Jan 9, 2025
@jprudent jprudent changed the title [ALPACA] Fix XRP pagination issue [Coin-Module] Fix XRP pagination issue Jan 9, 2025
hedi-edelbloute
hedi-edelbloute previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@hedi-edelbloute hedi-edelbloute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@jprudent jprudent force-pushed the fix_pagination_issues branch from f1bcb5d to 220058d Compare January 10, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedi-edelbloute hedi-edelbloute hedi-edelbloute left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jprudent jprudent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprudent @hedi-edelbloute