feat: Uniswap's term's of use #8842
Open
+57
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
lpaquet-ledger
previously approved these changes
Jan 8, 2025
sarneijim
reviewed
Jan 8, 2025
| if (!manifestId) return; | ||
| const termsOfUseUrl = termsOfUse.get(manifestId); | ||
| const appNameByAddr = transaction?.recipient === uniwapUniversalRouterAddr ? "Uniswap" : null; |
There was a problem hiding this comment.
Relocate Uniswap data to a common library, as this information is not exclusive to the desktop platform and unify the source.
(On the other hand, if the device is checking this address, it will be interested use the same source of true.)
dexProviders = [
{ name: "Uniswap",
addr:"0x3fC91A3afd70395Cd496C647d5a6CC9D4B2b7FAD" ]
There was a problem hiding this comment.
Please move the name, use generic solutions.
live-github-bot
bot
added
common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
❓ Context
🧐 Checklist for the PR Reviewers