Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat πŸ’„(llm): update LNX drawer in Reborn #8843

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jan 8, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • hardcoded lnx "drawer" screen

πŸ“ Description

Update of OLD LNX drawer in Reborn. It's not a real drawer (it's a screen) so I had to fake it a bit. But we need to keep it as a screen since it intercepts some navigations. Also it's called from drawers sometimes.

Also we need to be able to access to ledgershop from discover in readonly so Growth can opens the web view using a landing page and a deeplink

Demo with reborn LP ff ON and OFF
https://github.com/user-attachments/assets/a1bbe979-db0c-4ac3-a4db-61e163a26e16

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 9, 2025 2:19pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 2:19pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 2:19pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 2:19pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jan 8, 2025
@LucasWerey LucasWerey force-pushed the feat/LIVE-15654 branch 2 times, most recently from 2ce4767 to 1073f42 Compare January 9, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant