FIX: LIVE-15628: Convert account address to wallet api id which is the value expected by the dapp browser V2 #8858
Conversation
…by the dapp browser V2
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
live-github-bot
bot
added
desktop
apps/ledger-live-desktop/src/renderer/families/evm/AccountHeaderManageActions.ts
Outdated
Show resolved
Hide resolved
…r than just the id
| @@ -87,13 +87,13 @@ export function EthStakingModalBody({ | |||
|
|
|||
| const checkBoxOnChange = useCallback(() => { | |||
| const value = !doNotShowAgain; | |||
| global.localStorage.setItem(`${LOCAL_STORAGE_KEY_PREFIX}${account?.currency?.id}`, `${value}`); | |||
There was a problem hiding this comment.
I think it's important to use the currency id here and not account id as we want the checkBox to work on all accounts for a given currency
I think you should be able to use account?.currency for this
There was a problem hiding this comment.
This is a deprecated file, i checked on the codebase, it's not actually used anywhere. However I changed to account id as it's a key to store something on the local storage so it should in theory be unique, account?.currency wouldn't be unique as more accounts can be having the same currency. But let me know if you still want me to do the change, i don't mind
There was a problem hiding this comment.
Not sure why we still have it then but I would prefer to keep it correct for the logic
There was a problem hiding this comment.
yeah but then "However I changed to account id as it's a key to store something on the local storage so it should in theory be unique, account?.currency wouldn't be unique as more accounts can be having the same currency. But let me know if you still want me to do the change, i don't mind" ? if i change it to currency is it not gonna be unique i guess ? it's just a key for the local storage
There was a problem hiding this comment.
I think we can revert the changes (or most of them) in this file too now that we only use accountToWalletAPIAccount
There was a problem hiding this comment.
I thought the function wouldn't hurt. I used it on the same file, and it could be useful for that conversion on the outside. Do you still want me to revert it ?
There was a problem hiding this comment.
I suppose we could keep it
✅ Checklist
npx changesetwas attached.📝 Description
This PR converts the account address selected on LL to the wallet api id which is the value expected by the dapp browser V2
❓ Context
🧐 Checklist for the PR Reviewers