feat 💄(llm): change add accounts button logic #8859
+24
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
LucasWerey
force-pushed
the
feat/LIVE-15678
branch
from
66534fb to
ba56d0e
Compare
themooneer
reviewed
Jan 10, 2025
| @@ -71,7 +71,6 @@ describe("portfolioAssets", () => { | |||
|
|
|||
| expect(await screen.getByTestId("AssetsList")).toBeVisible(); | |||
| expect(screen.queryByText(/see all assets/i)).toBeNull(); | |||
| expect(screen.getByText(/add account/i)).toBeVisible(); | |||
There was a problem hiding this comment.
can you add a test case where the button add account is visible ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Change add account button apparition on portfolio screen with the new accounts list
Update inte test in consequence
No button on assets list if less than 5 assets
See all assets if equal or more than 5 assets
Add account button on accounts list
See all accounts button if equal or more than 5 accounts
If nothing default add account button
❓ Context
🧐 Checklist for the PR Reviewers