Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧡 (llm): optimize launch #8866

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jan 10, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

⚑ Launch Performance Comparison in dev

Thread Before Before 2 After 1 After 2
getBle 53ms 54ms 56ms 60ms
getSettings 70ms 66ms 57ms 61ms
listCachedCurrencyIds 103ms 85ms 57ms 62ms
hydrateCurrency 412ms, 441ms 452ms, 416ms 415ms, 424ms 451ms, 460ms
listSupportedFiats 451ms, 484ms 531ms, 500ms 415ms, 424ms 452ms, 460ms
getsupportedCountervalues 454ms, 485ms 532ms, 501ms 415ms, 425ms 452ms, 460ms
importSettings 454ms, 485ms 532ms, 501ms 415ms, 425ms 452ms, 461ms
getAccounts 557ms, 516ms 598ms, 567ms 450ms, 446ms 453ms, 488ms
getPostOnboardingState 698ms, 616ms 666ms, 634ms 488ms, 485ms 491ms, 524ms
getMarketState 715ms, 749ms 681ms, 654ms 488ms, 486ms 492ms, 524ms
getTrustchainState 732ms, 765ms 698ms, 666ms 489ms, 486ms 492ms, 524ms
getWalletExportState 748ms, 782ms 719ms, 683ms 489ms, 486ms 492ms, 524ms
getProtect 765ms, 799ms 731ms, 700ms 489ms, 486ms 492ms, 524ms
getCountervalues 800ms, 834ms 767ms 489ms, 486ms 492ms, 524ms
onInitFinished 858ms 791ms 510ms 551ms

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 11:06am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 11:06am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 11:06am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 11:06am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant